From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong information of ldo23 and ldo25 Date: Fri, 6 Jan 2017 09:05:39 +0200 Message-ID: <20170106070539.wd3kfhi77pa5ekcy@kozik-lap> References: <1483675149-32598-1-git-send-email-jcsing.lee@samsung.com> <1483675149-32598-2-git-send-email-jcsing.lee@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1483675149-32598-2-git-send-email-jcsing.lee@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jaechul Lee Cc: Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Andi Shyti , Chanwoo Choi , Catalin Marinas , Dmitry Torokhov , Will Deacon , linux-kernel@vger.kernel.org, Rob Herring , Javier Martinez Canillas , Kukjin Kim , Krzysztof Kozlowski , linux-input@vger.kernel.org, galaxyra@gmail.com, beomho.seo@samsung.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Fri, Jan 06, 2017 at 12:59:05PM +0900, Jaechul Lee wrote: > From: Chanwoo Choi > > This patch fixes the wrong information of ldo23 and ldo25 on both TM2 and TM2E. Please describe what is exactly wrong and how it affects the system/user. This is going to the fixes so it needs a good explanation. > > Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board") > Signed-off-by: Chanwoo Choi > Signed-off-by: Andi Shyti > Signed-off-by: Jaechul Lee > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 7 ++++--- > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 10 ---------- > 2 files changed, 4 insertions(+), 13 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index 3b5215c..e8971f4 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -504,9 +504,9 @@ > }; > > ldo23_reg: LDO23 { > - regulator-name = "CAM_SEN_CORE_1.2V_AP"; > + regulator-name = "CAM_SEN_CORE_1.05V_AP"; > regulator-min-microvolt = <1050000>; > - regulator-max-microvolt = <1200000>; > + regulator-max-microvolt = <1050000>; > }; > > ldo24_reg: LDO24 { > @@ -516,9 +516,10 @@ > }; > > ldo25_reg: LDO25 { > - regulator-name = "CAM_SEN_A2.8V_AP"; > + regulator-name = "UNUSED_LDO25"; > regulator-min-microvolt = <2800000>; > regulator-max-microvolt = <2800000>; > + regulator-always-off; Don't add it. See my other patch. Best regards, Krzysztof > }; > > ldo26_reg: LDO26 { > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts > index 1db4e7f..854c583 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts > @@ -18,16 +18,6 @@ > compatible = "samsung,tm2e", "samsung,exynos5433"; > }; > > -&ldo23_reg { > - regulator-name = "CAM_SEN_CORE_1.025V_AP"; > - regulator-max-microvolt = <1050000>; > -}; > - > -&ldo25_reg { > - regulator-name = "UNUSED_LDO25"; > - regulator-always-off; > -}; > - > &ldo31_reg { > regulator-name = "TSP_VDD_1.8V_AP"; > regulator-min-microvolt = <1800000>; > -- > 2.7.4 >