From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2] ARM: omap3: beagleboard-xm: dt: Add ethernet to the device tree Date: Fri, 6 Jan 2017 08:49:05 -0800 Message-ID: <20170106164904.GG2630@atomide.com> References: <1480713097-5931-1-git-send-email-laurent.pinchart@ideasonboard.com> <20170105163928.GD4310@atomide.com> <2557392.58vudoaMIY@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Laurent Pinchart , linux-omap , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , =?utf-8?Q?Beno=C3=AEt?= Cousson List-Id: devicetree@vger.kernel.org * Rob Herring [170105 10:51]: > On Thu, Jan 5, 2017 at 10:48 AM, Laurent Pinchart > wrote: > > Hello, > > > > On Thursday 05 Jan 2017 08:39:29 Tony Lindgren wrote: > >> * Rob Herring [170105 08:28]: > >> > On Fri, Dec 2, 2016 at 3:11 PM, Laurent Pinchart wrote: > >> >> The Beagleboard-xM has a LAN9514 USB hub and ethernet controller, > >> >> connected to port 2 of the OMAP EHCI controller. The board however has > >> >> no EEPROM to store the ethernet MAC address, which is programmed by the > >> >> boot loader. > >> >> > >> >> To allow Linux to use the same MAC address as the boot loader (or for > >> >> that matter any fixed MAC address), we need a node in the device tree > >> >> for the ethernet controller that the boot loader can update at runtime > >> >> with a local-mac-address property. Add it, along with an alias for the > >> >> ethernet controller to let the boot loader locate it easily. > >> >> > >> >> Signed-off-by: Laurent Pinchart > >> >> --- > >> >> Changes since v1: > >> >> > >> >> - Renamed usb2 DT node to hub > >> >> --- > >> >> > >> >> arch/arm/boot/dts/omap3-beagle-xm.dts | 16 ++++++++++++++++ > >> >> 1 file changed, 16 insertions(+) > >> >> > >> >> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts > >> >> b/arch/arm/boot/dts/omap3-beagle-xm.dts index > >> >> 85e297ed0ea1..673cee2234b2 100644 > >> >> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts > >> >> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts > >> >> @@ -27,6 +27,7 @@ > >> >> aliases { > >> >> display0 = &dvi0; > >> >> display1 = &tv0; > >> >> + ethernet = ðernet; > >> > > >> > Sorry, just noticed this, but this should be dropped. It's not used > >> > nor do we want an alias here. > >> > >> OK, will update locally as I have not pushed out yet. > > > > The ethernet alias is used by U-Boot to locate the ethernet controller and > > update the MAC address. > > Okay. Though with only only one, I don't see why that is hard to find. > Anyway, this is the least of u-boot's DT abuses. Applying Laurent's original patch then into omap-for-v4.11/dt. Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html