From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH RFC 3/4] dt-bindings: correct marvell orion MDIO binding document Date: Mon, 9 Jan 2017 10:31:56 +0000 Message-ID: <20170109103156.GA2147@leverpostej> References: <20170107112656.GL14217@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Russell King Cc: Thomas Petazzoni , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, netdev@vger.kernel.org, Rob Herring , Gregory Clement , Marcin Wojtas , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org On Sat, Jan 07, 2017 at 11:28:30AM +0000, Russell King wrote: > Correct the Marvell Orion MDIO binding document to properly reflect the > cases where an interrupt is present. Augment the examples to show this. > > Signed-off-by: Russell King This looks fine to me. Acked-by: Mark Rutland Mark. > --- > .../devicetree/bindings/net/marvell-orion-mdio.txt | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt > index 9417e54c26c0..ca733ff68ab9 100644 > --- a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt > +++ b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt > @@ -7,7 +7,10 @@ interface. > > Required properties: > - compatible: "marvell,orion-mdio" > -- reg: address and length of the SMI register > +- reg: address and length of the MDIO registers. When an interrupt is > + not present, the length is the size of the SMI register (4 bytes) > + otherwise it must be 0x84 bytes to cover the interrupt control > + registers. > > Optional properties: > - interrupts: interrupt line number for the SMI error/done interrupt > @@ -17,7 +20,7 @@ The child nodes of the MDIO driver are the individual PHY devices > connected to this MDIO bus. They must have a "reg" property given the > PHY address on the MDIO bus. > > -Example at the SoC level: > +Example at the SoC level without an interrupt property: > > mdio { > #address-cells = <1>; > @@ -26,6 +29,16 @@ mdio { > reg = <0xd0072004 0x4>; > }; > > +Example with an interrupt property: > + > +mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "marvell,orion-mdio"; > + reg = <0xd0072004 0x84>; > + interrupts = <30>; > +}; > + > And at the board level: > > mdio { > -- > 2.7.4 >