From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v7 5/8] IIO: add bindings for STM32 timer trigger driver Date: Mon, 9 Jan 2017 12:04:48 -0600 Message-ID: <20170109180448.f3pcpuarhcddo76b@rob-hp-laptop> References: <1483608344-9012-1-git-send-email-benjamin.gaignard@st.com> <1483608344-9012-6-git-send-email-benjamin.gaignard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1483608344-9012-6-git-send-email-benjamin.gaignard-qxv4g6HH51o@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Benjamin Gaignard Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, alexandre.torgue-qxv4g6HH51o@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, fabrice.gasnier-qxv4g6HH51o@public.gmane.org, gerald.baeza-qxv4g6HH51o@public.gmane.org, arnaud.pouliquen-qxv4g6HH51o@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, Benjamin Gaignard List-Id: devicetree@vger.kernel.org On Thu, Jan 05, 2017 at 10:25:41AM +0100, Benjamin Gaignard wrote: > Define bindings for STM32 timer trigger > > version 4: > - remove triggers enumeration from DT > - add reg parameter > > version 3: > - change file name > - add cross reference with mfd bindings > > version 2: > - only keep one compatible > - add DT parameters to set lists of the triggers: > one list describe the triggers created by the device > another one give the triggers accepted by the device > > Signed-off-by: Benjamin Gaignard > --- > .../bindings/iio/timer/stm32-timer-trigger.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > > diff --git a/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt b/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > new file mode 100644 > index 0000000..36a6c4a > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > @@ -0,0 +1,23 @@ > +STMicroelectronics STM32 Timers IIO timer bindings > + > +Must be a sub-node of an STM32 Timers device tree node. > +See ../mfd/stm32-timers.txt for details about the parent node. > + > +Required parameters: > +- compatible: Must be "st,stm32-timer-trigger". > +- reg: Define triggers configuration of the hardware IP. Valid values? Not sure this makes sense for use of reg. reg should be how you address or id a device. > + > +Example: > + timers@40010000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "st,stm32-timers"; > + reg = <0x40010000 0x400>; > + clocks = <&rcc 0 160>; > + clock-names = "clk_int"; > + > + timer { This would also need an unit address. > + compatible = "st,stm32-timer-trigger"; > + reg = <0>; > + }; > + }; > -- > 1.9.1 >