Re: [PATCH 4/5] ARM: dts: sunxi: add dtsi file for V3s SoC

Maxime Ripard
2017-01-10T18:21:06Z

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

On Tue, Jan 03, 2017 at 11:16:28PM +0800, Icenowy Zheng wrote:
> + uart0_pins_a: uart0@0 {
> + pins = "PB8", "PB9";
> + function = "uart0";
> + bias-pull-up;

Why do you need a pullup here?

Looks good otherwise.

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering