From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCHv3 3/8] rtc: add STM32 RTC driver Date: Wed, 11 Jan 2017 01:08:03 +0100 Message-ID: <20170111000803.mlie6kizcsj2o7lh@piout.net> References: <1483623809-29937-1-git-send-email-amelie.delaunay@st.com> <1483623809-29937-4-git-send-email-amelie.delaunay@st.com> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1483623809-29937-4-git-send-email-amelie.delaunay-qxv4g6HH51o@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Amelie Delaunay Cc: Alessandro Zummo , Rob Herring , Mark Rutland , Maxime Coquelin , Alexandre Torgue , Russell King , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Gabriel Fernandez List-Id: devicetree@vger.kernel.org Looks good to me, however... On 05/01/2017 at 14:43:24 +0100, Amelie Delaunay wrote : > +struct stm32_rtc { > + struct rtc_device *rtc_dev; > + void __iomem *base; > + struct clk *ck_rtc; > + spinlock_t lock; /* Protects registers accesses */ This spinlock seems to be useless, the rtc ops_lock is already protecting everywhere it is taken. > + int irq_alarm; > +}; > + [...] > +static int stm32_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) > +{ > + struct stm32_rtc *rtc = dev_get_drvdata(dev); > + struct rtc_time *tm = &alrm->time; > + unsigned long irqflags; > + unsigned int cr, isr, alrmar; > + int ret = 0; > + > + if (rtc_valid_tm(tm)) { > + dev_err(dev, "Alarm time not valid.\n"); > + return -EINVAL; This will never happen, tm is already checked multiple times (up to three) in the core before this function can be called. > + } > + You don't need to resend the whole series, just this patch. I'll take 2/8 and 3/8, the other ones can go through the stm32 tree. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.