From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: dts: OMAP5 / DRA7: indicate that SATA port 0 is available. Date: Fri, 13 Jan 2017 09:19:37 -0800 Message-ID: <20170113171936.GA2630@atomide.com> References: <1483964535-4298-1-git-send-email-jjhiblot@ti.com> <20170112223007.GP2630@atomide.com> <20170112223627.GQ2630@atomide.com> <423304d1-ffe3-ce7e-74d9-9707c391d501@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <423304d1-ffe3-ce7e-74d9-9707c391d501@ti.com> Sender: stable-owner@vger.kernel.org To: Jean-Jacques Hiblot Cc: bcousson@baylibre.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, rogerq@ti.com, stable@vger.kernel.org List-Id: devicetree@vger.kernel.org * Jean-Jacques Hiblot [170113 00:00]: > > > On 12/01/2017 23:36, Tony Lindgren wrote: > > * Tony Lindgren [170112 14:31]: > > > * Jean-Jacques Hiblot [170109 04:23]: > > > > AHCI provides the register PORTS_IMPL to let the software know which port > > > > is supported. The register must be initialized by the bootloader. However > > > > in some cases u-boot doesn't properly initialize this value (if it is not > > > > compiled with SATA support for example or if the SATA initialization fails). > > > > The DTS entry "ports-implemented" can be used to override the value in > > > > PORTS_IMPL. > > > > Adding this entry in the dts allows us no to worry about what is done by > > > > the bootloader. > > > Adding into omap-for-v4.11/dt thanks. > > Actually not applying just yet as I just noticed you tagged this for stable. > > > > Care to describe what breaks and on which devices without this patch? > Hi tony, > > Without this patch the SATA will not work in the following two cases: > * if there has been a failure to initialize SATA in u-boot. > * if ahci_platform module has been removed and re-inserted. The reason is > that the content of PORTS_IMPL is lost after the module is removed. I > suspect that it's because the controller is reset by the hwmod. OK I'll add that to the comments and apply into omap-for-v4.10/fixes. Thanks, Tony