From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 06/10] sata: ahci_da850: implement a softreset quirk Date: Sun, 15 Jan 2017 18:12:08 -0500 Message-ID: <20170115231208.GD14446@mtj.duckdns.org> References: <1484311084-31547-1-git-send-email-bgolaszewski@baylibre.com> <1484311084-31547-7-git-send-email-bgolaszewski@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1484311084-31547-7-git-send-email-bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bartosz Golaszewski Cc: Kevin Hilman , Sekhar Nori , Patrick Titiano , Michael Turquette , Rob Herring , Mark Rutland , Russell King , David Lechner , linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Jan 13, 2017 at 01:38:00PM +0100, Bartosz Golaszewski wrote: > +static int ahci_da850_softreset(struct ata_link *link, > + unsigned int *class, unsigned long deadline) > +{ > + int pmp, ret; > + > + pmp = sata_srst_pmp(link); > + > + ret = ahci_do_softreset(link, class, pmp, deadline, ahci_check_ready); > + if (pmp && ret == -EBUSY) > + return ahci_do_softreset(link, class, 0, > + deadline, ahci_check_ready); > + > + return ret; > +} Please add some comments explaining what's going on. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html