* [PATCH 0/2] ARM64: meson-gxm: R-Box Pro enablement @ 2017-01-17 3:06 Andreas Färber 2017-01-17 3:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber 2017-01-17 3:06 ` [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth Andreas Färber 0 siblings, 2 replies; 19+ messages in thread From: Andreas Färber @ 2017-01-17 3:06 UTC (permalink / raw) To: linux-amlogic Cc: devicetree, Kevin Hilman, linux-kernel, Carlo Caione, Andreas Färber, linux-arm-kernel Hello, This mini-series adds initial support for the Amlogic S912 based R-Box Pro TV boxes. Patch 1 should apply today, patch 2 depends on Martin's Bluetooth series. Wifi further depends on: https://patchwork.kernel.org/patch/9518447/ (and /etc/wifi/AP6255/nvram.txt as /lib/firmware/brcm/brcmfmac43455-sdio.txt) Regards, Andreas Cc: devicetree@vger.kernel.org Andreas Färber (2): ARM64: dts: meson-gxm: Add R-Box Pro ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth arch/arm64/boot/dts/amlogic/Makefile | 1 + arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts | 249 +++++++++++++++++++++ 2 files changed, 250 insertions(+) create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts -- 2.10.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro 2017-01-17 3:06 [PATCH 0/2] ARM64: meson-gxm: R-Box Pro enablement Andreas Färber @ 2017-01-17 3:06 ` Andreas Färber 2017-01-17 3:35 ` Andreas Färber ` (2 more replies) 2017-01-17 3:06 ` [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth Andreas Färber 1 sibling, 3 replies; 19+ messages in thread From: Andreas Färber @ 2017-01-17 3:06 UTC (permalink / raw) To: linux-amlogic Cc: Carlo Caione, Kevin Hilman, linux-arm-kernel, linux-kernel, Andreas Färber, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, devicetree The R-Box Pro is a TV box derived from Amlogic q200 reference design. It uses an AP6255 Wifi module. It features an LED tube that lights a surrounding stripe and the top logo in blue or red or pink'ish - blue is on by default, and red (i.e., pink) is configured as panic indicator. This device is available in at least two models, with 2 GB vs. 3 GB RAM as well as varying eMMC size. The intent is to handle this with a single .dts that gets the actual RAM size from U-Boot. The vendor prefix remains to be clarified, therefore no dedicated board compatible string yet. Signed-off-by: Andreas Färber <afaerber@suse.de> --- arch/arm64/boot/dts/amlogic/Makefile | 1 + arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts | 240 +++++++++++++++++++++ 2 files changed, 241 insertions(+) create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile index 0d7bfbf7d922..66bc809a5eae 100644 --- a/arch/arm64/boot/dts/amlogic/Makefile +++ b/arch/arm64/boot/dts/amlogic/Makefile @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-nexbox-a95x.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-s912-q200.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-s912-q201.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb always := $(dtb-y) subdir-y := $(dts-dirs) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts new file mode 100644 index 000000000000..9f04fa4e5aec --- /dev/null +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts @@ -0,0 +1,240 @@ +/* + * Copyright (c) 2016-2017 Andreas Färber + * + * Based on nexbox-a1: + * + * Copyright (c) 2016 BayLibre, SAS. + * Author: Neil Armstrong <narmstrong@baylibre.com> + * + * Copyright (c) 2016 Endless Computers, Inc. + * Author: Carlo Caione <carlo@endlessm.com> + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of the + * License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively, + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use, + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */ + +/dts-v1/; + +#include "meson-gxm.dtsi" + +/ { + compatible = "amlogic,s912", "amlogic,meson-gxm"; + model = "R-Box Pro"; + + aliases { + serial0 = &uart_AO; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + memory@0 { + device_type = "memory"; + reg = <0x0 0x0 0x0 0x80000000>; /* 2 GiB or 3 GiB */ + }; + + leds { + compatible = "gpio-leds"; + + blue { + label = "rbox-pro:blue:on"; + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>; + default-state = "on"; + }; + + red { + label = "rbox-pro:red:standby"; + gpios = <&gpio GPIODV_28 GPIO_ACTIVE_HIGH>; + default-state = "off"; + retain-state-suspended; + panic-indicator; + }; + }; + + vddio_boot: regulator-vddio-boot { + compatible = "regulator-fixed"; + regulator-name = "VDDIO_BOOT"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + vddao_3v3: regulator-vddao-3v3 { + compatible = "regulator-fixed"; + regulator-name = "VDDAO_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + + vcc_3v3: regulator-vcc-3v3 { + compatible = "regulator-fixed"; + regulator-name = "VCC_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + + emmc_pwrseq: emmc-pwrseq { + compatible = "mmc-pwrseq-emmc"; + reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; + }; + + wifi32k: wifi32k { + compatible = "pwm-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + pwms = <&pwm_ef 0 30518 0>; /* PWM_E at 32.768KHz */ + }; + + sdio_pwrseq: sdio-pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>; + clocks = <&wifi32k>; + clock-names = "ext_clock"; + }; +}; + +ðmac { + status = "okay"; + + pinctrl-0 = <ð_pins>; + pinctrl-names = "default"; + + /* Select external PHY by default */ + phy-handle = <&external_phy>; + + snps,reset-gpio = <&gpio GPIOZ_14 0>; + snps,reset-delays-us = <0 10000 1000000>; + snps,reset-active-low; + + amlogic,tx-delay-ns = <2>; + + /* External PHY is in RGMII */ + phy-mode = "rgmii"; +}; + +&external_mdio { + external_phy: ethernet-phy@0 { + compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22"; + reg = <0>; + max-speed = <1000>; + }; +}; + +&ir { + status = "okay"; + pinctrl-0 = <&remote_input_ao_pins>; + pinctrl-names = "default"; +}; + +&pwm_ef { + status = "okay"; + pinctrl-0 = <&pwm_e_pins>; + pinctrl-names = "default"; + clocks = <&clkc CLKID_FCLK_DIV4>; + clock-names = "clkin0"; +}; + +/* Wireless SDIO Module */ +&sd_emmc_a { + status = "okay"; + pinctrl-0 = <&sdio_pins>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + + bus-width = <4>; + cap-sd-highspeed; + max-frequency = <100000000>; + + non-removable; + disable-wp; + + mmc-pwrseq = <&sdio_pwrseq>; + + vmmc-supply = <&vddao_3v3>; + vqmmc-supply = <&vddio_boot>; + + brcmf: brcmf@1 { + reg = <1>; + compatible = "brcm,bcm4329-fmac"; + }; +}; + +/* SD card */ +&sd_emmc_b { + status = "okay"; + pinctrl-0 = <&sdcard_pins>; + pinctrl-names = "default"; + + bus-width = <4>; + cap-sd-highspeed; + max-frequency = <100000000>; + disable-wp; + + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>; + cd-inverted; + + vmmc-supply = <&vddao_3v3>; + vqmmc-supply = <&vddio_boot>; +}; + +/* eMMC */ +&sd_emmc_c { + status = "okay"; + pinctrl-0 = <&emmc_pins>; + pinctrl-names = "default"; + + bus-width = <8>; + cap-sd-highspeed; + cap-mmc-highspeed; + max-frequency = <200000000>; + non-removable; + disable-wp; + mmc-ddr-1_8v; + mmc-hs200-1_8v; + + mmc-pwrseq = <&emmc_pwrseq>; + vmmc-supply = <&vcc_3v3>; + vqmmc-supply = <&vddio_boot>; +}; + +&uart_AO { + status = "okay"; + pinctrl-0 = <&uart_ao_a_pins>; + pinctrl-names = "default"; +}; -- 2.10.2 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro 2017-01-17 3:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber @ 2017-01-17 3:35 ` Andreas Färber 2017-01-18 22:18 ` Kevin Hilman 2017-01-17 22:54 ` [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix Andreas Färber 2017-01-17 23:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber 2 siblings, 1 reply; 19+ messages in thread From: Andreas Färber @ 2017-01-17 3:35 UTC (permalink / raw) To: linux-amlogic Cc: Mark Rutland, devicetree, Kevin Hilman, Will Deacon, linux-kernel, Rob Herring, Catalin Marinas, Carlo Caione, linux-arm-kernel Am 17.01.2017 um 04:06 schrieb Andreas Färber: > + leds { > + compatible = "gpio-leds"; > + > + blue { > + label = "rbox-pro:blue:on"; > + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>; > + default-state = "on"; > + }; > + > + red { > + label = "rbox-pro:red:standby"; > + gpios = <&gpio GPIODV_28 GPIO_ACTIVE_HIGH>; > + default-state = "off"; > + retain-state-suspended; > + panic-indicator; > + }; > + }; The original property names for these two were led and red. If anyone has better label names than the above, please speak up. Ditto for vega-s95. On the odroidc2 it's called alive but uses heartbeat there. The vendor device tree had a third "mcu" GPIO in the sysled node, GPIOAO_6, which leads to immediate power-off. I tried using "gpio-poweroff" to configure this pin, but that driver fails to initialize because some pm callback is already registered - I assume from psci, which apparently succeeds to power-off the system, too. For comparison, the S905 based Vega S95 Telos has no such mcu property. Any thoughts? Also, any ideas how best to switch from blue to red for suspend? Add pinctrl properties above? systemd service doing echo from userspace? I assume in Android the Amlogic sysled driver handles all that logic - didn't find any suspend equivalent to gpio-poweroff. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro 2017-01-17 3:35 ` Andreas Färber @ 2017-01-18 22:18 ` Kevin Hilman 0 siblings, 0 replies; 19+ messages in thread From: Kevin Hilman @ 2017-01-18 22:18 UTC (permalink / raw) To: Andreas Färber Cc: Mark Rutland, devicetree, Catalin Marinas, Will Deacon, linux-kernel, Rob Herring, Carlo Caione, linux-amlogic, linux-arm-kernel Andreas Färber <afaerber@suse.de> writes: > Am 17.01.2017 um 04:06 schrieb Andreas Färber: >> + leds { >> + compatible = "gpio-leds"; >> + >> + blue { >> + label = "rbox-pro:blue:on"; >> + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>; >> + default-state = "on"; >> + }; >> + >> + red { >> + label = "rbox-pro:red:standby"; >> + gpios = <&gpio GPIODV_28 GPIO_ACTIVE_HIGH>; >> + default-state = "off"; >> + retain-state-suspended; >> + panic-indicator; >> + }; >> + }; > > The original property names for these two were led and red. If anyone > has better label names than the above, please speak up. Ditto for > vega-s95. On the odroidc2 it's called alive but uses heartbeat there. > > The vendor device tree had a third "mcu" GPIO in the sysled node, > GPIOAO_6, which leads to immediate power-off. I tried using > "gpio-poweroff" to configure this pin, but that driver fails to > initialize because some pm callback is already registered - I assume > from psci, which apparently succeeds to power-off the system, too. For > comparison, the S905 based Vega S95 Telos has no such mcu property. Any > thoughts? > > Also, any ideas how best to switch from blue to red for suspend? Add > pinctrl properties above? systemd service doing echo from userspace? I > assume in Android the Amlogic sysled driver handles all that logic - > didn't find any suspend equivalent to gpio-poweroff. in leds-gpio, when retain-state-suspended is not set, the LED is automatically set to value 0. I wonder if leds-gpio should grow support to make the suspend value configurable? Or a property like "toggle-state-suspended" ? Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix 2017-01-17 3:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber 2017-01-17 3:35 ` Andreas Färber @ 2017-01-17 22:54 ` Andreas Färber 2017-01-17 22:54 ` [PATCH 2/3] Documentation: devicetree: amlogic: Add R-Box Pro Andreas Färber [not found] ` <20170117225459.4438-1-afaerber-l3A5Bk7waGM@public.gmane.org> 2017-01-17 23:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber 2 siblings, 2 replies; 19+ messages in thread From: Andreas Färber @ 2017-01-17 22:54 UTC (permalink / raw) To: linux-amlogic Cc: Mark Rutland, devicetree, Kevin Hilman, linux-kernel, Rob Herring, Carlo Caione, ada, Andreas Färber, linux-arm-kernel Their domain name is spelled kingnoval, but textually Kingnovel. Cc: ada@kingnoval.com Signed-off-by: Andreas Färber <afaerber@suse.de> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 14fd1c24e1f0..b38301c4f3f0 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -156,6 +156,7 @@ karo Ka-Ro electronics GmbH keithkoep Keith & Koep GmbH keymile Keymile GmbH kinetic Kinetic Technologies +kingnovel Kingnovel Technology Co., Ltd. kosagi Sutajio Ko-Usagi PTE Ltd. kyo Kyocera Corporation lacie LaCie -- 2.10.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 2/3] Documentation: devicetree: amlogic: Add R-Box Pro 2017-01-17 22:54 ` [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix Andreas Färber @ 2017-01-17 22:54 ` Andreas Färber 2017-01-18 9:35 ` Neil Armstrong 2017-01-21 20:02 ` Rob Herring [not found] ` <20170117225459.4438-1-afaerber-l3A5Bk7waGM@public.gmane.org> 1 sibling, 2 replies; 19+ messages in thread From: Andreas Färber @ 2017-01-17 22:54 UTC (permalink / raw) To: linux-amlogic Cc: Carlo Caione, Kevin Hilman, linux-arm-kernel, linux-kernel, Andreas Färber, ada, Rob Herring, Mark Rutland, devicetree Cc: ada@kingnoval.com Signed-off-by: Andreas Färber <afaerber@suse.de> --- Originally I thought we would group by SoC (6, 8, 8b, gxbb, gxl, gmx, etc.) but this got out of order with nexbox,a95x - so inserting kingnovel between amlogic and nexbox here. If that's what we want going forward, we should move the old entries to make the scheme clearer. The alternative would be to reorder alphabetically within each SoC group, but nexbox,a95x with two SoCs makes it difficult to categorize, we could choose gxbb as the earlier one. Documentation/devicetree/bindings/arm/amlogic.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt index 9b2b41ab6817..fb0ee7d9a921 100644 --- a/Documentation/devicetree/bindings/arm/amlogic.txt +++ b/Documentation/devicetree/bindings/arm/amlogic.txt @@ -45,5 +45,6 @@ Board compatible values: - "amlogic,p231" (Meson gxl s905d) - "amlogic,q200" (Meson gxm s912) - "amlogic,q201" (Meson gxm s912) + - "kingnovel,r-box-pro" (Meson gxm S912) - "nexbox,a95x" (Meson gxbb or Meson gxl s905x) - "nexbox,a1" (Meson gxm s912) -- 2.10.2 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] Documentation: devicetree: amlogic: Add R-Box Pro 2017-01-17 22:54 ` [PATCH 2/3] Documentation: devicetree: amlogic: Add R-Box Pro Andreas Färber @ 2017-01-18 9:35 ` Neil Armstrong 2017-01-18 22:38 ` Andreas Färber 2017-01-21 20:02 ` Rob Herring 1 sibling, 1 reply; 19+ messages in thread From: Neil Armstrong @ 2017-01-18 9:35 UTC (permalink / raw) To: Andreas Färber, linux-amlogic Cc: Mark Rutland, devicetree, Kevin Hilman, linux-kernel, Rob Herring, Carlo Caione, ada, linux-arm-kernel On 01/17/2017 11:54 PM, Andreas Färber wrote: > Cc: ada@kingnoval.com > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > Originally I thought we would group by SoC (6, 8, 8b, gxbb, gxl, gmx, etc.) > but this got out of order with nexbox,a95x - so inserting kingnovel between > amlogic and nexbox here. If that's what we want going forward, we should move > the old entries to make the scheme clearer. The alternative would be to > reorder alphabetically within each SoC group, but nexbox,a95x with two SoCs > makes it difficult to categorize, we could choose gxbb as the earlier one. Andreas, Feel free to provide a fixup. Neil > > Documentation/devicetree/bindings/arm/amlogic.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt > index 9b2b41ab6817..fb0ee7d9a921 100644 > --- a/Documentation/devicetree/bindings/arm/amlogic.txt > +++ b/Documentation/devicetree/bindings/arm/amlogic.txt > @@ -45,5 +45,6 @@ Board compatible values: > - "amlogic,p231" (Meson gxl s905d) > - "amlogic,q200" (Meson gxm s912) > - "amlogic,q201" (Meson gxm s912) > + - "kingnovel,r-box-pro" (Meson gxm S912) > - "nexbox,a95x" (Meson gxbb or Meson gxl s905x) > - "nexbox,a1" (Meson gxm s912) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] Documentation: devicetree: amlogic: Add R-Box Pro 2017-01-18 9:35 ` Neil Armstrong @ 2017-01-18 22:38 ` Andreas Färber 2017-01-18 23:38 ` Kevin Hilman 0 siblings, 1 reply; 19+ messages in thread From: Andreas Färber @ 2017-01-18 22:38 UTC (permalink / raw) To: Neil Armstrong, linux-amlogic, Kevin Hilman, Carlo Caione Cc: Mark Rutland, devicetree, Rob Herring, linux-kernel, linux-arm-kernel Am 18.01.2017 um 10:35 schrieb Neil Armstrong: > On 01/17/2017 11:54 PM, Andreas Färber wrote: >> Cc: ada@kingnoval.com >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- >> Originally I thought we would group by SoC (6, 8, 8b, gxbb, gxl, gmx, etc.) >> but this got out of order with nexbox,a95x - so inserting kingnovel between >> amlogic and nexbox here. If that's what we want going forward, we should move >> the old entries to make the scheme clearer. The alternative would be to >> reorder alphabetically within each SoC group, but nexbox,a95x with two SoCs >> makes it difficult to categorize, we could choose gxbb as the earlier one. > > Andreas, > > Feel free to provide a fixup. Sure, the question is which way. ;) Kevin? Carlo? Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] Documentation: devicetree: amlogic: Add R-Box Pro 2017-01-18 22:38 ` Andreas Färber @ 2017-01-18 23:38 ` Kevin Hilman 0 siblings, 0 replies; 19+ messages in thread From: Kevin Hilman @ 2017-01-18 23:38 UTC (permalink / raw) To: Andreas Färber Cc: Mark Rutland, devicetree, Neil Armstrong, linux-kernel, Rob Herring, Carlo Caione, linux-amlogic, linux-arm-kernel Andreas Färber <afaerber@suse.de> writes: > Am 18.01.2017 um 10:35 schrieb Neil Armstrong: >> On 01/17/2017 11:54 PM, Andreas Färber wrote: >>> Cc: ada@kingnoval.com >>> Signed-off-by: Andreas Färber <afaerber@suse.de> >>> --- >>> Originally I thought we would group by SoC (6, 8, 8b, gxbb, gxl, gmx, etc.) >>> but this got out of order with nexbox,a95x - so inserting kingnovel between >>> amlogic and nexbox here. If that's what we want going forward, we should move >>> the old entries to make the scheme clearer. The alternative would be to >>> reorder alphabetically within each SoC group, but nexbox,a95x with two SoCs >>> makes it difficult to categorize, we could choose gxbb as the earlier one. >> >> Andreas, >> >> Feel free to provide a fixup. > > Sure, the question is which way. ;) Kevin? Carlo? I don't have a strong preference, but continuing to group by SoC makes the most sense based on what we have there now. Moving nexbox,a95x up to the first one (gxbb) is fine with me. Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] Documentation: devicetree: amlogic: Add R-Box Pro 2017-01-17 22:54 ` [PATCH 2/3] Documentation: devicetree: amlogic: Add R-Box Pro Andreas Färber 2017-01-18 9:35 ` Neil Armstrong @ 2017-01-21 20:02 ` Rob Herring 1 sibling, 0 replies; 19+ messages in thread From: Rob Herring @ 2017-01-21 20:02 UTC (permalink / raw) To: Andreas Färber Cc: Mark Rutland, devicetree, Kevin Hilman, linux-kernel, ada, Carlo Caione, linux-amlogic, linux-arm-kernel On Tue, Jan 17, 2017 at 11:54:58PM +0100, Andreas Färber wrote: > Cc: ada@kingnoval.com > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > Originally I thought we would group by SoC (6, 8, 8b, gxbb, gxl, gmx, etc.) > but this got out of order with nexbox,a95x - so inserting kingnovel between > amlogic and nexbox here. If that's what we want going forward, we should move > the old entries to make the scheme clearer. The alternative would be to > reorder alphabetically within each SoC group, but nexbox,a95x with two SoCs > makes it difficult to categorize, we could choose gxbb as the earlier one. > > Documentation/devicetree/bindings/arm/amlogic.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 19+ messages in thread
[parent not found: <20170117225459.4438-1-afaerber-l3A5Bk7waGM@public.gmane.org>]
* [PATCH 3/3] ARM64: dts: meson-gxm-rbox-pro: Add board compatible string [not found] ` <20170117225459.4438-1-afaerber-l3A5Bk7waGM@public.gmane.org> @ 2017-01-17 22:54 ` Andreas Färber [not found] ` <20170117225459.4438-3-afaerber-l3A5Bk7waGM@public.gmane.org> 2017-01-21 20:01 ` [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix Rob Herring 1 sibling, 1 reply; 19+ messages in thread From: Andreas Färber @ 2017-01-17 22:54 UTC (permalink / raw) To: linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Cc: Carlo Caione, Kevin Hilman, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Andreas Färber, ada-MUr+2Ic57fgS+FvcfC7Uqw, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA Cc: ada-MUr+2Ic57fgS+FvcfC7Uqw@public.gmane.org Signed-off-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org> --- To be squashed in v2. arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts index 6ea225f584bd..7ff02754cfde 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts @@ -53,7 +53,7 @@ #include "meson-gxm.dtsi" / { - compatible = "amlogic,s912", "amlogic,meson-gxm"; + compatible = "kingnovel,r-box-pro", "amlogic,s912", "amlogic,meson-gxm"; model = "R-Box Pro"; aliases { -- 2.10.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 19+ messages in thread
[parent not found: <20170117225459.4438-3-afaerber-l3A5Bk7waGM@public.gmane.org>]
* Re: [PATCH 3/3] ARM64: dts: meson-gxm-rbox-pro: Add board compatible string [not found] ` <20170117225459.4438-3-afaerber-l3A5Bk7waGM@public.gmane.org> @ 2017-01-23 18:21 ` Kevin Hilman [not found] ` <m2h94p3aee.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 19+ messages in thread From: Kevin Hilman @ 2017-01-23 18:21 UTC (permalink / raw) To: Andreas Färber Cc: linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Carlo Caione, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, ada-MUr+2Ic57fgS+FvcfC7Uqw, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org> writes: > Cc: ada-MUr+2Ic57fgS+FvcfC7Uqw@public.gmane.org > Signed-off-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org> > --- > To be squashed in v2. FYI, since you mention v2 here, i'll wait on this series and assume you'll update it on top of your cleanup series. Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 19+ messages in thread
[parent not found: <m2h94p3aee.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH 3/3] ARM64: dts: meson-gxm-rbox-pro: Add board compatible string [not found] ` <m2h94p3aee.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2017-01-23 18:32 ` Andreas Färber 0 siblings, 0 replies; 19+ messages in thread From: Andreas Färber @ 2017-01-23 18:32 UTC (permalink / raw) To: Kevin Hilman Cc: linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Carlo Caione, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, ada-MUr+2Ic57fgS+FvcfC7Uqw, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA Am 23.01.2017 um 19:21 schrieb Kevin Hilman: > Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org> writes: > >> Cc: ada-MUr+2Ic57fgS+FvcfC7Uqw@public.gmane.org >> Signed-off-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org> >> --- >> To be squashed in v2. > > FYI, since you mention v2 here, i'll wait on this series and assume > you'll update it on top of your cleanup series. Yes, I am waiting on the board documentation cleanup to be merged before I rebase though. The others shouldn't matter here. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix [not found] ` <20170117225459.4438-1-afaerber-l3A5Bk7waGM@public.gmane.org> 2017-01-17 22:54 ` [PATCH 3/3] ARM64: dts: meson-gxm-rbox-pro: Add board compatible string Andreas Färber @ 2017-01-21 20:01 ` Rob Herring 1 sibling, 0 replies; 19+ messages in thread From: Rob Herring @ 2017-01-21 20:01 UTC (permalink / raw) To: Andreas Färber Cc: linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Carlo Caione, Kevin Hilman, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, ada-MUr+2Ic57fgS+FvcfC7Uqw, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 17, 2017 at 11:54:57PM +0100, Andreas Färber wrote: > Their domain name is spelled kingnoval, but textually Kingnovel. > > Cc: ada-MUr+2Ic57fgS+FvcfC7Uqw@public.gmane.org > Signed-off-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org> > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro 2017-01-17 3:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber 2017-01-17 3:35 ` Andreas Färber 2017-01-17 22:54 ` [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix Andreas Färber @ 2017-01-17 23:06 ` Andreas Färber 2017-01-18 22:27 ` Kevin Hilman 2 siblings, 1 reply; 19+ messages in thread From: Andreas Färber @ 2017-01-17 23:06 UTC (permalink / raw) To: linux-amlogic Cc: Mark Rutland, devicetree, Kevin Hilman, Will Deacon, linux-kernel, Rob Herring, Catalin Marinas, Carlo Caione, linux-arm-kernel Am 17.01.2017 um 04:06 schrieb Andreas Färber: > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index 0d7bfbf7d922..66bc809a5eae 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-nexbox-a95x.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-s912-q200.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-s912-q201.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb What is the logic behind meson-gxm-s912-q201 vs. meson-gxm-nexbox-a1? Should it be renamed to include -s912 for consistency? > +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb Should this new board use meson-gxm-s912-? > > always := $(dtb-y) > subdir-y := $(dts-dirs) Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro 2017-01-17 23:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber @ 2017-01-18 22:27 ` Kevin Hilman 2017-01-19 8:10 ` Neil Armstrong 0 siblings, 1 reply; 19+ messages in thread From: Kevin Hilman @ 2017-01-18 22:27 UTC (permalink / raw) To: Andreas Färber Cc: linux-amlogic, Mark Rutland, devicetree, Will Deacon, linux-kernel, Rob Herring, Catalin Marinas, Carlo Caione, linux-arm-kernel Andreas Färber <afaerber@suse.de> writes: > Am 17.01.2017 um 04:06 schrieb Andreas Färber: >> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile >> index 0d7bfbf7d922..66bc809a5eae 100644 >> --- a/arch/arm64/boot/dts/amlogic/Makefile >> +++ b/arch/arm64/boot/dts/amlogic/Makefile >> @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-nexbox-a95x.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-s912-q200.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-s912-q201.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb > > What is the logic behind meson-gxm-s912-q201 vs. meson-gxm-nexbox-a1? > Should it be renamed to include -s912 for consistency? Oops, I think it should be renamed for consistency. I believe there's only one chip in the GXM family (S912) so it might be that we could either drop the -s912 from the q20x boards or, add it to the nexbox. I lean towards dropping the -s912 since there's a single chip in GXM. (FWIW, GXL has more than one chip in the family so we added the chip there.) >> +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb > > Should this new board use meson-gxm-s912-? No. Unless Neil or you thing otherwise, I think we should send a patch to drop the -s912 from the q20x boards instead. (where "we" == Neil) ;) Kevin ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro 2017-01-18 22:27 ` Kevin Hilman @ 2017-01-19 8:10 ` Neil Armstrong 0 siblings, 0 replies; 19+ messages in thread From: Neil Armstrong @ 2017-01-19 8:10 UTC (permalink / raw) To: Kevin Hilman, Andreas Färber Cc: Mark Rutland, devicetree, Catalin Marinas, Will Deacon, linux-kernel, Rob Herring, Carlo Caione, linux-amlogic, linux-arm-kernel Hi Andreas, Kevin, On 01/18/2017 11:27 PM, Kevin Hilman wrote: > Andreas Färber <afaerber@suse.de> writes: > >> Am 17.01.2017 um 04:06 schrieb Andreas Färber: >>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile >>> index 0d7bfbf7d922..66bc809a5eae 100644 >>> --- a/arch/arm64/boot/dts/amlogic/Makefile >>> +++ b/arch/arm64/boot/dts/amlogic/Makefile >>> @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-nexbox-a95x.dtb >>> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-s912-q200.dtb >>> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-s912-q201.dtb >>> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb >> >> What is the logic behind meson-gxm-s912-q201 vs. meson-gxm-nexbox-a1? >> Should it be renamed to include -s912 for consistency? It followed the GXL logic... until I posted the nexbox-a1 without ! Since the q20x and p23x boards are the same, it was to enforce the fact that the S912 was on the q200 and q201 boards. > Oops, I think it should be renamed for consistency. > > I believe there's only one chip in the GXM family (S912) so it might be > that we could either drop the -s912 from the q20x boards or, add it to > the nexbox. I believe this aswell AFAIK. > > I lean towards dropping the -s912 since there's a single chip in GXM. > (FWIW, GXL has more than one chip in the family so we added the chip > there.) > >>> +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb >> >> Should this new board use meson-gxm-s912-? > > No. Unless Neil or you thing otherwise, I think we should send a patch > to drop the -s912 from the q20x boards instead. (where "we" == Neil) ;) Ok, will do. > > Kevin Neil ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth 2017-01-17 3:06 [PATCH 0/2] ARM64: meson-gxm: R-Box Pro enablement Andreas Färber 2017-01-17 3:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber @ 2017-01-17 3:06 ` Andreas Färber 2017-01-18 22:29 ` Kevin Hilman 1 sibling, 1 reply; 19+ messages in thread From: Andreas Färber @ 2017-01-17 3:06 UTC (permalink / raw) To: linux-amlogic Cc: Mark Rutland, devicetree, Kevin Hilman, Will Deacon, linux-kernel, Rob Herring, Catalin Marinas, Carlo Caione, Andreas Färber, linux-arm-kernel Add an SDIO reset GPIO and enable the serial used by the AP6255 Bluetooth module. Based on work by Martin Blumenstingl. Signed-off-by: Andreas Färber <afaerber@suse.de> --- arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts index 9f04fa4e5aec..6ea225f584bd 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts @@ -58,6 +58,7 @@ aliases { serial0 = &uart_AO; + serial1 = &uart_A; }; chosen { @@ -122,7 +123,8 @@ sdio_pwrseq: sdio-pwrseq { compatible = "mmc-pwrseq-simple"; - reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>; + reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>, + <&gpio GPIOX_17 GPIO_ACTIVE_LOW>; clocks = <&wifi32k>; clock-names = "ext_clock"; }; @@ -238,3 +240,10 @@ pinctrl-0 = <&uart_ao_a_pins>; pinctrl-names = "default"; }; + +&uart_A { + status = "okay"; + pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>; + pinctrl-names = "default"; + uart-has-rtscts; +}; -- 2.10.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth 2017-01-17 3:06 ` [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth Andreas Färber @ 2017-01-18 22:29 ` Kevin Hilman 0 siblings, 0 replies; 19+ messages in thread From: Kevin Hilman @ 2017-01-18 22:29 UTC (permalink / raw) To: Andreas Färber Cc: Mark Rutland, devicetree, Catalin Marinas, Will Deacon, linux-kernel, Rob Herring, Carlo Caione, linux-amlogic, linux-arm-kernel Andreas Färber <afaerber@suse.de> writes: > Add an SDIO reset GPIO and enable the serial used by the AP6255 > Bluetooth module. Based on work by Martin Blumenstingl. > > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts > index 9f04fa4e5aec..6ea225f584bd 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts > @@ -58,6 +58,7 @@ > > aliases { > serial0 = &uart_AO; > + serial1 = &uart_A; > }; > > chosen { > @@ -122,7 +123,8 @@ > > sdio_pwrseq: sdio-pwrseq { > compatible = "mmc-pwrseq-simple"; > - reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>; > + reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>, > + <&gpio GPIOX_17 GPIO_ACTIVE_LOW>; > clocks = <&wifi32k>; > clock-names = "ext_clock"; c.f. thread on Martin's series. I don't like this (ab)use of reset-gpios for sdio-pwrseq, and there's some work coming that will make this much cleaner. So, I'll hold off on this until the other solution is ready. Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2017-01-23 18:32 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-17 3:06 [PATCH 0/2] ARM64: meson-gxm: R-Box Pro enablement Andreas Färber
2017-01-17 3:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber
2017-01-17 3:35 ` Andreas Färber
2017-01-18 22:18 ` Kevin Hilman
2017-01-17 22:54 ` [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix Andreas Färber
2017-01-17 22:54 ` [PATCH 2/3] Documentation: devicetree: amlogic: Add R-Box Pro Andreas Färber
2017-01-18 9:35 ` Neil Armstrong
2017-01-18 22:38 ` Andreas Färber
2017-01-18 23:38 ` Kevin Hilman
2017-01-21 20:02 ` Rob Herring
[not found] ` <20170117225459.4438-1-afaerber-l3A5Bk7waGM@public.gmane.org>
2017-01-17 22:54 ` [PATCH 3/3] ARM64: dts: meson-gxm-rbox-pro: Add board compatible string Andreas Färber
[not found] ` <20170117225459.4438-3-afaerber-l3A5Bk7waGM@public.gmane.org>
2017-01-23 18:21 ` Kevin Hilman
[not found] ` <m2h94p3aee.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-01-23 18:32 ` Andreas Färber
2017-01-21 20:01 ` [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix Rob Herring
2017-01-17 23:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber
2017-01-18 22:27 ` Kevin Hilman
2017-01-19 8:10 ` Neil Armstrong
2017-01-17 3:06 ` [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth Andreas Färber
2017-01-18 22:29 ` Kevin Hilman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).