From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 2/2] arm64: dts: exynos: Add regulators for Vbus and Vbus-Boost Date: Tue, 17 Jan 2017 20:28:26 +0200 Message-ID: <20170117182826.gngf7gjkvfyg3uww@kozik-lap> References: <1484665444-23365-1-git-send-email-pankaj.dubey@samsung.com> <1484665444-23365-3-git-send-email-pankaj.dubey@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1484665444-23365-3-git-send-email-pankaj.dubey@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Pankaj Dubey Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, robh+dt@kernel.org, Vivek Gautam , javier@osg.samsung.com, kgene@kernel.org, krzk@kernel.org, sanath@samsung.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Tue, Jan 17, 2017 at 08:34:04PM +0530, Pankaj Dubey wrote: > From: Vivek Gautam > > Adding fixed voltage regulators for Vbus and Vbus-boost required > by USB 3.0 DRD controller on Exynos7-espresso board. > > Reviewed-by: Javier Martinez Canillas > Signed-off-by: Vivek Gautam > Signed-off-by: Pankaj Dubey Same as patch 1. > --- > arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 45 +++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > index 9cf73cf..8d5abdd 100644 > --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > @@ -13,6 +13,7 @@ > #include "exynos7.dtsi" > #include > #include > +#include > > / { > model = "Samsung Exynos7 Espresso board based on EXYNOS7"; > @@ -33,6 +34,29 @@ > device_type = "memory"; > reg = <0x0 0x40000000 0x0 0xC0000000>; > }; > + > + usb30_vbus_reg: regulator-usb30 { > + compatible = "regulator-fixed"; > + regulator-name = "VBUS_5V"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&gph1 1 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usb30_vbus_en>; > + enable-active-high; > + }; > + > + usb3drd_boost_5v: regulator-usb3drd-boost { > + compatible = "regulator-fixed"; > + regulator-name = "VUSB_VBUS_5V"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&gpf4 1 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usb3drd_boost_en>; > + enable-active-high; > + }; > + > }; > > &fin_pll { > @@ -366,3 +390,24 @@ > vqmmc-supply = <&ldo2_reg>; > disable-wp; > }; > + > +&usbdrd_phy { > + vbus-supply = <&usb30_vbus_reg>; > + vbus-boost-supply = <&usb3drd_boost_5v>; > +}; > + > +&pinctrl_bus1 { > + usb30_vbus_en: usb30-vbus-en { > + samsung,pins = "gph1-1"; > + samsung,pin-function = <1>; Javier mentioned it, please use EXYNOS_PIN_FUNC_OUTPUT > + samsung,pin-pud = <0>; EXYNOS_PIN_PULL_NONE > + samsung,pin-drv = <0>; I think these are the same as in Exynos5422, so EXYNOS5420_PIN_DRV_LV1 Best regards, Krzysztof > + }; > + > + usb3drd_boost_en: usb3drd-boost-en { > + samsung,pins = "gpf4-1"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > +}; > -- > 2.7.4 >