From: Wolfram Sang <wsa@the-dreams.de>
To: Chris Brandt <chris.brandt@renesas.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Simon Horman <horms@verge.net.au>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
devicetree@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks
Date: Tue, 17 Jan 2017 21:30:18 +0100 [thread overview]
Message-ID: <20170117203017.r3g43scvrkwpe6kt@ninjato> (raw)
In-Reply-To: <20170117195940.25092-2-chris.brandt@renesas.com>
Hi Chris,
> + struct clk *clk2;
I'd vote for 'clk_cd' since we are explicitly requesting that clock for
it.
> + ret = clk_prepare_enable(priv->clk2);
> + if (ret < 0)
> + return ret;
You need to disable clk when failing.
Regards,
Wolfram
next prev parent reply other threads:[~2017-01-17 20:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 19:59 [PATCH v2 0/3] mmc: sh_mobile_sdhi: fix missing r7s72100 clocks Chris Brandt
[not found] ` <20170117195940.25092-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-01-17 19:59 ` [PATCH v2 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks Chris Brandt
2017-01-17 20:30 ` Wolfram Sang [this message]
2017-01-18 14:53 ` Chris Brandt
2017-01-17 19:59 ` [PATCH v2 3/3] ARM: dts: r7s72100: update sdhi clock bindings Chris Brandt
[not found] ` <20170117195940.25092-4-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-01-18 8:41 ` Geert Uytterhoeven
2017-01-17 19:59 ` [PATCH v2 2/3] mmc: sh_mobile_sdhi: explain " Chris Brandt
2017-01-17 20:33 ` Wolfram Sang
2017-01-18 14:58 ` Chris Brandt
[not found] ` <20170117195940.25092-3-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-01-18 8:44 ` Geert Uytterhoeven
2017-01-18 15:11 ` Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117203017.r3g43scvrkwpe6kt@ninjato \
--to=wsa@the-dreams.de \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).