From: Andi Shyti <andi.shyti@samsung.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH 1/3] Input: add STMicroelectronics FingerTip touchscreen driver
Date: Wed, 18 Jan 2017 10:16:39 +0900 [thread overview]
Message-ID: <20170118011639.rkhaoh7xkh2szju3@gangnam.samsung> (raw)
In-Reply-To: <20170117204711.GB6888@dtor-ws>
Hi Dmitry,
> > > +- ledvdd-supply : power supply to the touch key leds
> >
> > Is this really optional? If yes... how it gets the power when not
> > provided?
>
> Also, is this really a regulator? Given you are testing whether it is on
> or off to report LED state it feels to me it might be a GPIO pin, not
> regulator...
In this case it's a real regulator, not a GPIO. But even if it
was a GPIO, I still could use gpio-regulator[*] which handles
gpio using the regulator framework. In this case, depending on
how the leds are enabled on the DTS, in the driver I would use
only one api (regulators indeed) for both the cases.
Thanks,
Andi
[*] Documentation/devicetree/bindings/regulator/gpio-regulator.txt
next prev parent reply other threads:[~2017-01-18 1:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170117135456epcas5p25968e1781a9cee833b350940ae7af70b@epcas5p2.samsung.com>
2017-01-17 13:54 ` [PATCH 0/3] STM FingerTip S touchscreen support for TM2 board Andi Shyti
[not found] ` <CGME20170117135456epcas5p2e303f0c5fa642b43fde543d5d6098dc2@epcas5p2.samsung.com>
2017-01-17 13:54 ` [PATCH 1/3] Input: add STMicroelectronics FingerTip touchscreen driver Andi Shyti
2017-01-17 14:32 ` Javier Martinez Canillas
2017-01-17 18:43 ` Krzysztof Kozlowski
2017-01-17 20:47 ` Dmitry Torokhov
2017-01-18 1:16 ` Andi Shyti [this message]
2017-01-18 1:12 ` Andi Shyti
2017-01-19 18:19 ` Rob Herring
2017-01-20 0:19 ` Andi Shyti
2017-01-20 13:22 ` Rob Herring
[not found] ` <CGME20170117135456epcas5p25a2bfb3a8e1e785177ea842310401d24@epcas5p2.samsung.com>
2017-01-17 13:54 ` [PATCH 2/3] Input: add support for the STMicroelectronics FingerTip touchscreen Andi Shyti
2017-01-17 21:21 ` Dmitry Torokhov
2017-01-18 1:58 ` Andi Shyti
[not found] ` <CGME20170117135457epcas5p2044e9e5cd9eb6b162bb0acb4e317bdfb@epcas5p2.samsung.com>
2017-01-17 13:54 ` [PATCH 3/3] arm64: dts: exynos: Add stmfts touchscreen node for TM2 and TM2E Andi Shyti
2017-01-17 14:35 ` Javier Martinez Canillas
2017-01-17 18:39 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118011639.rkhaoh7xkh2szju3@gangnam.samsung \
--to=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=javier@osg.samsung.com \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).