From: Jelle van der Waa <jelle-oJJ1AqDjjO4@public.gmane.org>
To: Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] input: touchscreen: add driver for Zeitec ZET6223
Date: Wed, 18 Jan 2017 21:57:14 +0100 [thread overview]
Message-ID: <20170118205712.GA5333@gmail.com> (raw)
In-Reply-To: <20170114191425.GA31309@dtor-ws>
On 01/14/17 at 11:14am, Dmitry Torokhov wrote:
> > +
> > +static const struct of_device_id zet6223_of_match[] = {
> > + { .compatible = "zeitec", "zet6223" },
>
> The compatible should be "zeitec,zet6223", what you have here is
> equivalent of:
>
> { .compatible = "zeitec", .data = "zet6223" },
Ah that was silly, thanks :)
> I also have been looking at you previosu submission and had some draft
> changes. I reconciled them in the patch below, if it still works for you
> then I'll fold everything together and apply. Please let me know.
I'll find some time to test the patch below, I've one small suggestion
to the patch below.
> + ts->fingernum = buf[15] & 0x7F;
> + if (ts->fingernum > ZET6223_MAX_FINGERS) {
> + dev_warn(&ts->client->dev,
> + "touchpanel reports %d fingers, limiting to %d\n",
> + ts->fingernum, ZET6223_MAX_FINGERS);
> + ts->fingernum = 16;
Maybe use ZET6223_MAX_FINGERS?
--
Jelle van der Waa
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-18 20:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 16:32 [PATCH 1/2] input: touchscreen: add driver for Zeitec ZET6223 Jelle van der Waa
2016-12-23 16:32 ` [PATCH 2/2] devicetree: add vendor prefix for Zeitec Jelle van der Waa
2017-01-03 15:25 ` Rob Herring
[not found] ` <20161223163214.7716-1-jelle-oJJ1AqDjjO4@public.gmane.org>
2017-01-03 15:24 ` [PATCH 1/2] input: touchscreen: add driver for Zeitec ZET6223 Rob Herring
2017-01-14 19:14 ` Dmitry Torokhov
2017-01-18 20:57 ` Jelle van der Waa [this message]
2017-01-18 22:49 ` Dmitry Torokhov
2017-01-31 8:19 ` Dmitry Torokhov
2017-02-01 19:10 ` Jelle van der Waa
[not found] ` <20170201191058.GA8453-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-01 19:20 ` Dmitry Torokhov
2017-02-01 19:23 ` Dmitry Torokhov
2017-02-01 19:30 ` Dmitry Torokhov
2017-02-01 19:35 ` Jelle van der Waa
[not found] ` <20170201193554.GB8453-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-01 22:47 ` Dmitry Torokhov
2017-02-09 21:38 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118205712.GA5333@gmail.com \
--to=jelle-ojj1aqdjjo4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).