From: Thierry Reding <thierry.reding@gmail.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
lars@metafoo.de, alexandre.torgue@st.com,
linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org,
arnaud.pouliquen@st.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
pmeerw@pmeerw.net, knaack.h@gmx.de, gerald.baeza@st.com,
fabrice.gasnier@st.com, lee.jones@linaro.org,
linaro-kernel@lists.linaro.org, jic23@kernel.org,
Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCH v8 4/8] PWM: add PWM driver for STM32 plaftorm
Date: Thu, 19 Jan 2017 10:08:41 +0100 [thread overview]
Message-ID: <20170119090841.GB28834@ulmo.ba.sec> (raw)
In-Reply-To: <1484749251-14445-5-git-send-email-benjamin.gaignard@st.com>
[-- Attachment #1.1: Type: text/plain, Size: 1321 bytes --]
On Wed, Jan 18, 2017 at 03:20:47PM +0100, Benjamin Gaignard wrote:
> This driver adds support for PWM driver on STM32 platform.
> The SoC have multiple instances of the hardware IP and each
> of them could have small differences: number of channels,
> complementary output, auto reload register size...
>
> version 8:
> - fix comments done by Thierry on version 7
>
> version 6:
> - change st,breakinput parameter to make it usuable for stm32f7 too.
>
> version 4:
> - detect at probe time hardware capabilities
> - fix comments done on v2 and v3
> - use PWM atomic ops
>
> version 2:
> - only keep one comptatible
> - use DT parameters to discover hardware block configuration
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> drivers/pwm/Kconfig | 9 ++
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-stm32.c | 398 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 408 insertions(+)
> create mode 100644 drivers/pwm/pwm-stm32.c
Similar nit than for 3/8. The canonical prefix for PWM subsystem patches
is "pwm: ". One other thing that I had missed earlier...
> +MODULE_ALIAS("platform: stm32-pwm");
I don't think there should be a space after ':'.
With those two fixed:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-01-19 9:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 14:20 [PATCH v8 0/8] Add PWM and IIO timer drivers for STM32 Benjamin Gaignard
2017-01-18 14:20 ` [PATCH v8 1/8] MFD: add bindings for STM32 Timers driver Benjamin Gaignard
2017-01-18 14:20 ` [PATCH v8 2/8] MFD: add " Benjamin Gaignard
2017-01-18 14:20 ` [PATCH v8 3/8] PWM: add pwm-stm32 DT bindings Benjamin Gaignard
2017-01-19 9:04 ` Thierry Reding
2017-01-18 14:20 ` [PATCH v8 4/8] PWM: add PWM driver for STM32 plaftorm Benjamin Gaignard
2017-01-19 9:08 ` Thierry Reding [this message]
2017-01-18 14:20 ` [PATCH v8 5/8] IIO: add bindings for STM32 timer trigger driver Benjamin Gaignard
[not found] ` <1484749251-14445-6-git-send-email-benjamin.gaignard-qxv4g6HH51o@public.gmane.org>
2017-01-19 19:31 ` Rob Herring
[not found] ` <1484749251-14445-1-git-send-email-benjamin.gaignard-qxv4g6HH51o@public.gmane.org>
2017-01-18 14:20 ` [PATCH v8 6/8] IIO: add " Benjamin Gaignard
2017-01-18 14:20 ` [PATCH v8 7/8] ARM: dts: stm32: add Timers driver for stm32f429 MCU Benjamin Gaignard
2017-01-18 14:20 ` [PATCH v8 8/8] ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco Benjamin Gaignard
2017-01-19 8:43 ` [PATCH v8 0/8] Add PWM and IIO timer drivers for STM32 Lee Jones
2017-01-19 16:02 ` Benjamin Gaignard
2017-01-19 19:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119090841.GB28834@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=arnaud.pouliquen@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=gerald.baeza@st.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).