From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Juri Lelli <juri.lelli@arm.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org,
linux-pm@vger.kernel.org, peterz@infradead.org,
catalin.marinas@arm.com, broonie@kernel.org, will.deacon@arm.com,
linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
robh+dt@kernel.org, gregkh@linuxfoundation.org,
sudeep.holla@arm.com, morten.rasmussen@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/7] arm, arm64: factorize common cpu capacity default code
Date: Thu, 19 Jan 2017 14:53:34 +0000 [thread overview]
Message-ID: <20170119145333.GB27312@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170119143757.14537-7-juri.lelli@arm.com>
On Thu, Jan 19, 2017 at 02:37:56PM +0000, Juri Lelli wrote:
> +extern unsigned long
> +arch_scale_cpu_capacity(struct sched_domain *sd, int cpu);
> +extern void set_capacity_scale(unsigned int cpu, unsigned long capacity);
These should be in a header file (please run your code through sparse).
> +extern bool cap_parsing_failed;
> +extern void normalize_cpu_capacity(void);
> +extern int __init parse_cpu_capacity(struct device_node *cpu_node, int cpu);
Same for these.
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> new file mode 100644
> index 000000000000..3faf89518892
> --- /dev/null
> +++ b/drivers/base/arch_topology.c
> @@ -0,0 +1,240 @@
> +/*
> + * driver/base/arch_topology.c - Arch specific cpu topology information
> + *
> + * Written by: Juri Lelli, ARM Ltd.
> + *
> + * Copyright (C) 2016, ARM Ltd.
> + *
> + * All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
The files that you've taken this code from are GPLv2, but you've thrown
a GPLv2+ header on a file that's merely a copy of the original code.
As some of the code you've moved to this new file is from Nicolas and
Vincent, you need to seek their approval to make this change of license
terms, or keep the original license terms.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-01-19 14:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 14:37 [PATCH 0/7] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-01-19 14:37 ` [PATCH 1/7] Documentation: arm: fix wrong reference number in DT definition Juri Lelli
2017-01-21 20:55 ` Rob Herring
[not found] ` <20170119143757.14537-1-juri.lelli-5wv7dgnIgG8@public.gmane.org>
2017-01-19 14:37 ` [PATCH 2/7] Documentation/ABI: add information about cpu_capacity Juri Lelli
2017-01-19 14:37 ` [PATCH 6/7] arm, arm64: factorize common cpu capacity default code Juri Lelli
2017-01-19 14:53 ` Russell King - ARM Linux [this message]
[not found] ` <20170119145333.GB27312-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-01-19 15:51 ` Juri Lelli
2017-01-19 16:00 ` Dietmar Eggemann
2017-01-20 10:42 ` Juri Lelli
2017-01-19 14:37 ` [PATCH 3/7] arm: fix return value of parse_cpu_capacity Juri Lelli
2017-01-19 14:37 ` [PATCH 4/7] arm: remove wrong CONFIG_PROC_SYSCTL ifdef Juri Lelli
2017-01-19 14:37 ` [PATCH 5/7] arm64: " Juri Lelli
2017-01-19 14:37 ` [PATCH 7/7] arm,arm64,drivers: reduce scope of cap_parsing_failed Juri Lelli
2017-01-30 12:29 ` [PATCH 0/7] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-01-30 17:51 ` Catalin Marinas
2017-01-30 18:21 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119145333.GB27312@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=juri.lelli@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).