devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/6] clk: sunxi-ng: add support for V3s CCU
Date: Fri, 20 Jan 2017 21:38:13 +0100	[thread overview]
Message-ID: <20170120203813.buj4d4wciuwnd2ey@lukather> (raw)
In-Reply-To: <20170119175448.11445-3-icenowy@aosc.xyz>


[-- Attachment #1.1: Type: text/plain, Size: 699 bytes --]

On Fri, Jan 20, 2017 at 01:54:45AM +0800, Icenowy Zheng wrote:
> V3s has a similar but cut-down CCU to H3. Some muxes, especially clocks
> about CSI, are different, which makes it to need a new CCU driver.
> 
> Add such a new driver for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---

Having a changelog somewhere would help. Why did you drop your cover
letter?

> +static const char * const mbus_parents[] = { "osc24M", "pll-periph0-2x", "pll-ddr" };

This is more that 80 characters and triggers a warning in
checkpatch...

Anyway, fixed and applied.
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2017-01-20 20:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19 17:54 [PATCH v3 1/6] dt-bindings: add device tree binding for Allwinner V3s pinctrl Icenowy Zheng
2017-01-19 17:54 ` [PATCH v3 2/6] arm: sunxi: add support for V3s SoC Icenowy Zheng
2017-01-20 20:29   ` Maxime Ripard
2017-01-19 17:54 ` [PATCH v3 3/6] clk: sunxi-ng: add support for V3s CCU Icenowy Zheng
2017-01-20 20:38   ` Maxime Ripard [this message]
2017-01-19 17:54 ` [PATCH v3 4/6] dt-bindings: add device binding for the CCU of Allwinner V3s Icenowy Zheng
2017-01-20 20:32   ` Maxime Ripard
2017-01-19 17:54 ` [PATCH v3 5/6] ARM: dts: sunxi: add dtsi file for V3s SoC Icenowy Zheng
2017-01-20 20:48   ` Maxime Ripard
2017-01-19 17:54 ` [PATCH v3 6/6] ARM: dts: sunxi: add support for Lichee Pi Zero board Icenowy Zheng
2017-01-20 20:48   ` Maxime Ripard
2017-01-20 20:24 ` [PATCH v3 1/6] dt-bindings: add device tree binding for Allwinner V3s pinctrl Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170120203813.buj4d4wciuwnd2ey@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.xyz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).