From: Icenowy Zheng <icenowy@aosc.xyz>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH v3 5/6] ARM: dts: sunxi: add dtsi file for V3s SoC
Date: Sat, 21 Jan 2017 05:03:37 +0800 [thread overview]
Message-ID: <20170122132430.OPRqpr7U@smtp2j.mail.yandex.net> (raw)
2017年1月21日 04:48于 Maxime Ripard <maxime.ripard@free-electrons.com>写道：
>
> On Fri, Jan 20, 2017 at 01:54:47AM +0800, Icenowy Zheng wrote:
> > As we have the pinctrl and clock support for the V3s SoC, it's now to
> > run a mainline Linux on it.
> >
> > So add a .dtsi file for it.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> Next time, please provide a description of what that SoC in your
> commit log.
>
> > + rtc: rtc@01c20400 {
> > + compatible = "allwinner,sun6i-a31-rtc";
> > + reg = <0x01c20400 0x54>;
> > + interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
> > + };
>
> Did you have the chance to actually test how the RTC was behaving?
>
> Other RTC have been pretty bad at keeping time, this is probably
> something you want to check.
Currently no...
>
> Applied,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
next reply other threads:[~2017-01-20 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 21:03 Icenowy Zheng [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-19 17:54 [PATCH v3 1/6] dt-bindings: add device tree binding for Allwinner V3s pinctrl Icenowy Zheng
2017-01-19 17:54 ` [PATCH v3 5/6] ARM: dts: sunxi: add dtsi file for V3s SoC Icenowy Zheng
2017-01-20 20:48 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170122132430.OPRqpr7U@smtp2j.mail.yandex.net \
--to=icenowy@aosc.xyz \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox