From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v5 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay Date: Tue, 24 Jan 2017 13:36:13 -0500 (EST) Message-ID: <20170124.133613.1355073769005063451.davem@davemloft.net> References: <20161217182119.4037-1-martin.blumenstingl@googlemail.com> <20170122220246.13602-1-martin.blumenstingl@googlemail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170122220246.13602-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org, khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org From: Martin Blumenstingl Date: Sun, 22 Jan 2017 23:02:44 +0100 > Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 > cycle (= 2ns) TX clock delay. This seems to work fine for many boards > (for example Odroid-C2 or Amlogic's reference boards) but there are > some others where TX traffic is simply broken. > There are probably multiple reasons why it's working on some boards > while it's broken on others: > - some of Amlogic's reference boards are using a Micrel PHY > - hardware circuit design > - maybe more... > > iperf3 results on my Mecool BB2 board (Meson GXM, RTL8211F PHY) with > TX clock delay disabled on the MAC (as it's enabled in the PHY driver). > TX throughput was virtually zero before: ... > I get similar TX throughput on my Meson GXBB "MXQ Pro+" board when I > disable the PHY's TX-delay and configure a 4ms TX-delay on the MAC. > So changes to at least the RTL8211F PHY driver are needed to get it > working properly in all situations. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html