Devicetree
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Alessandro Zummo
	<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 0/7] rtc: sun6i: Fix the RTC accuracy
Date: Tue, 24 Jan 2017 18:49:35 +0100	[thread overview]
Message-ID: <20170124174935.att4s7mqfbyxkxqk@piout.net> (raw)
In-Reply-To: <cover.6bd4d4760c24d09845ad09c212fcd487d78da5ad.1485168100.git-series.maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Hi,

On 23/01/2017 at 11:41:45 +0100, Maxime Ripard wrote :
> Hi,
> 
> The RTC used in the A31 and later SoC has an accuracy issue, which is
> already significant even after a couple of hours.
> 
> This is due to the fact that the oscillator used by default is an internal
> and very inaccurate one.
> 
> A first attempt at fixing that by switching to the external oscillator was
> done in the patch "rtc: sun6i: Switch to the external oscillator". However,
> it turned out to be problematic since it was tracked properly in the clock
> framework, which might lead to some clocks being disabled, even though
> their devices were not notified.
> 
> This is a second attempt, this time by making it part of the CCF. It
> turned out to be a bit more complicated than one would expect since the mux
> found inside the RTC also controls one of the input of the main clock unit.
> Therefore, it needs to be probed before the main clock unit driver.
> 
> Let me know what you think,
> Maxime
> 
> Changes from v1:
>   - Force the muxing to the external oscillator even for old DT
>   - Make the patches a bit more stable friendly
>   - Change the bindings to have a cell of 1, to account for the external
>     output of the oscillator
>   - Split the driver remove() removal into a separate patch and switched to
>     devm
>   - Reordered the patches
> 
> Maxime Ripard (7):
>   rtc: sun6i: Disable the build as a module
>   rtc: sun6i: Add some locking
>   rtc: sun6i: Switch to the external oscillator
>   rtc: sun6i: Expose the 32kHz oscillator
>   rtc: sun6i: Switch to devm_rtc_device_register
>   ARM: sun8i: a23/a33: Enable the real LOSC and use it
>   ARM: sun8i: a23/a33: Add the oscillators accuracy
> 

I've applied 1/7 to 5/7. Thanks!

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

  parent reply	other threads:[~2017-01-24 17:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23 10:41 [PATCH v2 0/7] rtc: sun6i: Fix the RTC accuracy Maxime Ripard
2017-01-23 10:41 ` [PATCH v2 3/7] rtc: sun6i: Switch to the external oscillator Maxime Ripard
     [not found] ` <cover.6bd4d4760c24d09845ad09c212fcd487d78da5ad.1485168100.git-series.maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-01-23 10:41   ` [PATCH v2 1/7] rtc: sun6i: Disable the build as a module Maxime Ripard
2017-01-23 10:41   ` [PATCH v2 2/7] rtc: sun6i: Add some locking Maxime Ripard
2017-01-23 10:41   ` [PATCH v2 4/7] rtc: sun6i: Expose the 32kHz oscillator Maxime Ripard
     [not found]     ` <f244737aa43965e5510e8173b5653deb484a94f0.1485168100.git-series.maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-01-23 21:00       ` Rob Herring
2017-01-23 10:41   ` [PATCH v2 5/7] rtc: sun6i: Switch to devm_rtc_device_register Maxime Ripard
2017-01-23 10:41   ` [PATCH v2 6/7] ARM: sun8i: a23/a33: Enable the real LOSC and use it Maxime Ripard
2017-01-23 10:41   ` [PATCH v2 7/7] ARM: sun8i: a23/a33: Add the oscillators accuracy Maxime Ripard
2017-01-24 17:49   ` Alexandre Belloni [this message]
     [not found]     ` <20170124174935.att4s7mqfbyxkxqk-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2017-01-25 15:36       ` [PATCH v2 0/7] rtc: sun6i: Fix the RTC accuracy Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170124174935.att4s7mqfbyxkxqk@piout.net \
    --to=alexandre.belloni-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
    --cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox