From: David Miller <davem@davemloft.net>
To: green.hu@gmail.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
andrew@lunn.ch, arnd@arndb.de, jiri@resnulli.us,
linux-kernel@vger.kernel.org, f.fainelli@gmail.com,
robh+dt@kernel.org, mark.rutland@arm.com
Subject: Re: [PATCH v4] net: ethernet: faraday: To support device tree usage.
Date: Wed, 25 Jan 2017 12:34:48 -0500 (EST) [thread overview]
Message-ID: <20170125.123448.742815192519658537.davem@davemloft.net> (raw)
In-Reply-To: <20170124084606.GA11764@app09>
From: Greentime Hu <green.hu@gmail.com>
Date: Tue, 24 Jan 2017 16:46:14 +0800
> We also use the same binding document to describe the same faraday ethernet
> controller and add faraday to vendor-prefixes.txt.
>
> Signed-off-by: Greentime Hu <green.hu@gmail.com>
> ---
> Changes in v4:
> - Use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt.
> Changes in v3:
> - Nothing changed in this patch but I have committed andestech to vendor-prefixes.txt.
> Changes in v2:
> - Change atmac100_of_ids to ftmac100_of_ids
>
> ---
> .../net/{moxa,moxart-mac.txt => faraday,ftmac.txt} | 7 +++++--
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++
> 3 files changed, 13 insertions(+), 2 deletions(-)
> rename Documentation/devicetree/bindings/net/{moxa,moxart-mac.txt => faraday,ftmac.txt} (68%)
>
> diff --git a/Documentation/devicetree/bindings/net/moxa,moxart-mac.txt b/Documentation/devicetree/bindings/net/faraday,ftmac.txt
> similarity index 68%
> rename from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt
> rename to Documentation/devicetree/bindings/net/faraday,ftmac.txt
Why are you renaming the MOXA binding file instead of adding a completely new one
for faraday? The MOXA one should stick around, I don't see a justification for
removing it.
next prev parent reply other threads:[~2017-01-25 17:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 8:46 [PATCH v4] net: ethernet: faraday: To support device tree usage Greentime Hu
2017-01-25 17:34 ` David Miller [this message]
[not found] ` <20170125.123448.742815192519658537.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-01-25 21:09 ` Arnd Bergmann
[not found] ` <CAK8P3a2Zr6=4x8JRa313DQ2ND0V=8eL0yKkrd93wbdxkiOtmSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-27 22:17 ` Rob Herring
2017-02-01 15:47 ` Arnd Bergmann
2017-02-08 11:59 ` Greentime Hu
2017-02-10 15:03 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2017-01-05 10:23 Greentime Hu
2017-01-05 21:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125.123448.742815192519658537.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=green.hu@gmail.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).