From: David Miller <davem@davemloft.net>
To: john@phrozen.org
Cc: robh+dt@kernel.org, matthias.bgg@gmail.com,
netdev@vger.kernel.org, sean.wang@mediatek.com,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] Documentation: devicetree: change the mediatek ethernet compatible string
Date: Wed, 25 Jan 2017 14:36:13 -0500 (EST) [thread overview]
Message-ID: <20170125.143613.634538648038125925.davem@davemloft.net> (raw)
In-Reply-To: <1485332455-34743-1-git-send-email-john@phrozen.org>
From: John Crispin <john@phrozen.org>
Date: Wed, 25 Jan 2017 09:20:54 +0100
> When the binding was defined, I was not aware that mt2701 was an earlier
> version of the SoC. For sake of consistency, the ethernet driver should
> use mt2701 inside the compat string as this is the earliest SoC with the
> ethernet core.
>
> The ethernet driver is currently of no real use until we finish and
> upstream the DSA driver. There are no users of this binding yet. It should
> be safe to fix this now before it is too late and we need to provide
> backward compatibility for the mt7623-eth compat string.
>
> Reported-by: Sean Wang <sean.wang@mediatek.com>
> Signed-off-by: John Crispin <john@phrozen.org>
Applied.
next prev parent reply other threads:[~2017-01-25 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 8:20 [PATCH 1/2] Documentation: devicetree: change the mediatek ethernet compatible string John Crispin
2017-01-25 8:20 ` [PATCH 2/2] net-next: ethernet: mediatek: change the " John Crispin
[not found] ` <1485332455-34743-2-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2017-01-25 19:36 ` David Miller
2017-02-02 5:07 ` James Liao
[not found] ` <1485332455-34743-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2017-01-25 10:43 ` [PATCH 1/2] Documentation: devicetree: change the mediatek ethernet " Matthias Brugger
2017-01-27 22:41 ` Rob Herring
2017-01-25 19:36 ` David Miller [this message]
2017-02-02 5:07 ` James Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125.143613.634538648038125925.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).