[PATCH v2 1/6] ARM: tegra: nyan: Use proper IRQ type definitions

[PATCH v2 1/6] ARM: tegra: nyan: Use proper IRQ type definitions

[Paul Kocialkowski]

This switches a few interrupt definitions that were using
GPIO_ACTIVE_HIGH as IRQ type, which is invalid.

This is mostly a cosmetic change, that doesn't affect any driver.

Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
---
 arch/arm/boot/dts/tegra124-nyan.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi
index eabfa655a3cd..ef430aa30152 100644
--- a/arch/arm/boot/dts/tegra124-nyan.dtsi
+++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
@@ -65,7 +65,7 @@
 			compatible = "maxim,max98090";
 			reg = <0x10>;
 			interrupt-parent = <&gpio>;
-			interrupts = <TEGRA_GPIO(H, 4) GPIO_ACTIVE_HIGH>;
+			interrupts = <TEGRA_GPIO(H, 4) IRQ_TYPE_EDGE_FALLING>;
 		};
 
 		temperature-sensor@4c {
@@ -331,7 +331,7 @@
 					reg = <0x9>;
 					interrupt-parent = <&gpio>;
 					interrupts = <TEGRA_GPIO(J, 0)
-							GPIO_ACTIVE_HIGH>;
+							IRQ_TYPE_EDGE_BOTH>;
 					ti,ac-detect-gpios = <&gpio
 							TEGRA_GPIO(J, 0)
 							GPIO_ACTIVE_HIGH>;
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 3/6] ARM: tegra: nyan-big: Include compatible revisions for proper detection

[Paul Kocialkowski]

Depthcharge (the payload used with cros devices) will attempt to detect
boards using their revision. This includes all the known revisions for
the nyan-big board so that the dtb can be selected preferably.

Defining compatibly revisions allows depthcharge to select the kernel
via the revision it detects instead of using the default kernel. This
allows having a FIT image with multiple kernels for multiple devices.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 arch/arm/boot/dts/tegra124-nyan-big.dts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
index 67d7cfb32541..f12ece9b76a6 100644
--- a/arch/arm/boot/dts/tegra124-nyan-big.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
@@ -6,7 +6,12 @@
 
 / {
 	model = "Acer Chromebook 13 CB5-311";
-	compatible = "google,nyan-big", "nvidia,tegra124";
+	compatible = "google,nyan-big-rev7", "google,nyan-big-rev6",
+			"google,nyan-big-rev5", "google,nyan-big-rev4",
+			"google,nyan-big-rev3", "google,nyan-big-rev2",
+			"google,nyan-big-rev5", "google,nyan-big-rev4",
+			"google,nyan-big-rev1", "google,nyan-big-rev0",
+			"google,nyan-big", "google,nyan", "nvidia,tegra124";
 
 	panel: panel {
 		compatible = "auo,b133xtn01";
-- 
2.11.0

Re: [PATCH v2 3/6] ARM: tegra: nyan-big: Include compatible revisions for proper detection

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]

On Sun, Jan 22, 2017 at 04:47:50PM +0100, Paul Kocialkowski wrote:
> Depthcharge (the payload used with cros devices) will attempt to detect
> boards using their revision. This includes all the known revisions for
> the nyan-big board so that the dtb can be selected preferably.
> 
> Defining compatibly revisions allows depthcharge to select the kernel
> via the revision it detects instead of using the default kernel. This
> allows having a FIT image with multiple kernels for multiple devices.
> 
> Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
> ---
>  arch/arm/boot/dts/tegra124-nyan-big.dts | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

I've applied this, with a small change, see below.

> diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
> index 67d7cfb32541..f12ece9b76a6 100644
> --- a/arch/arm/boot/dts/tegra124-nyan-big.dts
> +++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
> @@ -6,7 +6,12 @@
>  
>  / {
>  	model = "Acer Chromebook 13 CB5-311";
> -	compatible = "google,nyan-big", "nvidia,tegra124";
> +	compatible = "google,nyan-big-rev7", "google,nyan-big-rev6",
> +			"google,nyan-big-rev5", "google,nyan-big-rev4",
> +			"google,nyan-big-rev3", "google,nyan-big-rev2",
> +			"google,nyan-big-rev5", "google,nyan-big-rev4",

This line is the same as two lines above, so I've removed this one. I've
also used slightly different padding (two tabs and align to the first
string in the first line with spaces) to make it consistent with other
string lists in the file.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 3/6] ARM: tegra: nyan-big: Include compatible revisions for proper detection

[Paul Kocialkowski]

[-- Attachment #1: Type: text/plain, Size: 2224 bytes --]

Le mercredi 25 janvier 2017 à 12:02 +0100, Thierry Reding a écrit :
> On Sun, Jan 22, 2017 at 04:47:50PM +0100, Paul Kocialkowski wrote:
> > Depthcharge (the payload used with cros devices) will attempt to detect
> > boards using their revision. This includes all the known revisions for
> > the nyan-big board so that the dtb can be selected preferably.
> > 
> > Defining compatibly revisions allows depthcharge to select the kernel
> > via the revision it detects instead of using the default kernel. This
> > allows having a FIT image with multiple kernels for multiple devices.
> > 
> > Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/tegra124-nyan-big.dts | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> I've applied this, with a small change, see below.
> 
> > diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts
> > b/arch/arm/boot/dts/tegra124-nyan-big.dts
> > index 67d7cfb32541..f12ece9b76a6 100644
> > --- a/arch/arm/boot/dts/tegra124-nyan-big.dts
> > +++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
> > @@ -6,7 +6,12 @@
> >  
> >  / {
> >  	model = "Acer Chromebook 13 CB5-311";
> > -	compatible = "google,nyan-big", "nvidia,tegra124";
> > +	compatible = "google,nyan-big-rev7", "google,nyan-big-rev6",
> > +			"google,nyan-big-rev5", "google,nyan-big-rev4",
> > +			"google,nyan-big-rev3", "google,nyan-big-rev2",
> > +			"google,nyan-big-rev5", "google,nyan-big-rev4",
> 
> This line is the same as two lines above, so I've removed this one. I've
> also used slightly different padding (two tabs and align to the first
> string in the first line with spaces) to make it consistent with other
> string lists in the file.

Oops, sorry I missed that last faulty line. Actually, it should have contained:
"google,nyan-blaze-rev1", "google,nyan-blaze-rev0";

instead so that all revision, from 7 down to 0 are covered.

Should I make another patch on top to fix that?

-- 
Paul Kocialkowski, developer of free digital technology at the lower levels

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 3/6] ARM: tegra: nyan-big: Include compatible revisions for proper detection

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 2431 bytes --]

On Wed, Jan 25, 2017 at 12:08:08PM +0100, Paul Kocialkowski wrote:
> Le mercredi 25 janvier 2017 à 12:02 +0100, Thierry Reding a écrit :
> > On Sun, Jan 22, 2017 at 04:47:50PM +0100, Paul Kocialkowski wrote:
> > > Depthcharge (the payload used with cros devices) will attempt to detect
> > > boards using their revision. This includes all the known revisions for
> > > the nyan-big board so that the dtb can be selected preferably.
> > > 
> > > Defining compatibly revisions allows depthcharge to select the kernel
> > > via the revision it detects instead of using the default kernel. This
> > > allows having a FIT image with multiple kernels for multiple devices.
> > > 
> > > Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
> > > ---
> > >  arch/arm/boot/dts/tegra124-nyan-big.dts | 7 ++++++-
> > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > I've applied this, with a small change, see below.
> > 
> > > diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts
> > > b/arch/arm/boot/dts/tegra124-nyan-big.dts
> > > index 67d7cfb32541..f12ece9b76a6 100644
> > > --- a/arch/arm/boot/dts/tegra124-nyan-big.dts
> > > +++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
> > > @@ -6,7 +6,12 @@
> > >  
> > >  / {
> > >  	model = "Acer Chromebook 13 CB5-311";
> > > -	compatible = "google,nyan-big", "nvidia,tegra124";
> > > +	compatible = "google,nyan-big-rev7", "google,nyan-big-rev6",
> > > +			"google,nyan-big-rev5", "google,nyan-big-rev4",
> > > +			"google,nyan-big-rev3", "google,nyan-big-rev2",
> > > +			"google,nyan-big-rev5", "google,nyan-big-rev4",
> > 
> > This line is the same as two lines above, so I've removed this one. I've
> > also used slightly different padding (two tabs and align to the first
> > string in the first line with spaces) to make it consistent with other
> > string lists in the file.
> 
> Oops, sorry I missed that last faulty line. Actually, it should have contained:
> "google,nyan-blaze-rev1", "google,nyan-blaze-rev0";
> 
> instead so that all revision, from 7 down to 0 are covered.
> 
> Should I make another patch on top to fix that?

Here's what I've put into Tegra's for-next, that has all the necessary
revisions, doesn't it?

	https://git.kernel.org/cgit/linux/kernel/git/tegra/linux.git/commit/?h=for-next&id=bfa3c0d4e8ba8eff525d34dbde0e76a98ebfbade

If so, no need for another patch.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 3/6] ARM: tegra: nyan-big: Include compatible revisions for proper detection

[Paul Kocialkowski]

[-- Attachment #1: Type: text/plain, Size: 2850 bytes --]

Le mercredi 25 janvier 2017 à 12:14 +0100, Thierry Reding a écrit :
> On Wed, Jan 25, 2017 at 12:08:08PM +0100, Paul Kocialkowski wrote:
> > Le mercredi 25 janvier 2017 à 12:02 +0100, Thierry Reding a écrit :
> > > On Sun, Jan 22, 2017 at 04:47:50PM +0100, Paul Kocialkowski wrote:
> > > > Depthcharge (the payload used with cros devices) will attempt to detect
> > > > boards using their revision. This includes all the known revisions for
> > > > the nyan-big board so that the dtb can be selected preferably.
> > > > 
> > > > Defining compatibly revisions allows depthcharge to select the kernel
> > > > via the revision it detects instead of using the default kernel. This
> > > > allows having a FIT image with multiple kernels for multiple devices.
> > > > 
> > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > > ---
> > > >  arch/arm/boot/dts/tegra124-nyan-big.dts | 7 ++++++-
> > > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > > 
> > > I've applied this, with a small change, see below.
> > > 
> > > > diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts
> > > > b/arch/arm/boot/dts/tegra124-nyan-big.dts
> > > > index 67d7cfb32541..f12ece9b76a6 100644
> > > > --- a/arch/arm/boot/dts/tegra124-nyan-big.dts
> > > > +++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
> > > > @@ -6,7 +6,12 @@
> > > >  
> > > >  / {
> > > >  	model = "Acer Chromebook 13 CB5-311";
> > > > -	compatible = "google,nyan-big", "nvidia,tegra124";
> > > > +	compatible = "google,nyan-big-rev7", "google,nyan-big-rev6",
> > > > +			"google,nyan-big-rev5", "google,nyan-big-rev4",
> > > > +			"google,nyan-big-rev3", "google,nyan-big-rev2",
> > > > +			"google,nyan-big-rev5", "google,nyan-big-rev4",
> > > 
> > > This line is the same as two lines above, so I've removed this one. I've
> > > also used slightly different padding (two tabs and align to the first
> > > string in the first line with spaces) to make it consistent with other
> > > string lists in the file.
> > 
> > Oops, sorry I missed that last faulty line. Actually, it should have
> > contained:
> > "google,nyan-blaze-rev1", "google,nyan-blaze-rev0";
> > 
> > instead so that all revision, from 7 down to 0 are covered.
> > 
> > Should I make another patch on top to fix that?
> 
> Here's what I've put into Tegra's for-next, that has all the necessary
> revisions, doesn't it?
> 
> 	https://git.kernel.org/cgit/linux/kernel/git/tegra/linux.git/commit/?h=f
> or-next&id=bfa3c0d4e8ba8eff525d34dbde0e76a98ebfbade
> 
> If so, no need for another patch.

Excellent, it's all there! Thanks a bunch.

-- 
Paul Kocialkowski, developer of free digital technology at the lower levels

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH v2 2/6] ARM: tegra: nyan: Use external control for bq24735 charger

[Paul Kocialkowski]

Nyan boards come with an embedded controller that controls when to
enable and disable the charge. Thus, it should not be left up to the
kernel to handle that.

Using the ti,external-control property allows specifying this use-case.

Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
---
 arch/arm/boot/dts/tegra124-nyan.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi
index ef430aa30152..5cf987b5401e 100644
--- a/arch/arm/boot/dts/tegra124-nyan.dtsi
+++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
@@ -335,6 +335,7 @@
 					ti,ac-detect-gpios = <&gpio
 							TEGRA_GPIO(J, 0)
 							GPIO_ACTIVE_HIGH>;
+					ti,external-control;
 				};
 
 				battery: sbs-battery@b {
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/6] ARM: tegra: nyan: Use external control for bq24735 charger

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

On Sun, Jan 22, 2017 at 04:47:49PM +0100, Paul Kocialkowski wrote:
> Nyan boards come with an embedded controller that controls when to
> enable and disable the charge. Thus, it should not be left up to the
> kernel to handle that.
> 
> Using the ti,external-control property allows specifying this use-case.
> 
> Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
> ---
>  arch/arm/boot/dts/tegra124-nyan.dtsi | 1 +
>  1 file changed, 1 insertion(+)

Is the ti,ac-detect-gpios property still useful in that case? I guess it
would still allow to monitor whether or not a charger is connected, even
if the EC determines that it shouldn't charge.

Anyway, I've applied this.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 2/6] ARM: tegra: nyan: Use external control for bq24735 charger

[Paul Kocialkowski]

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

Le mercredi 25 janvier 2017 à 11:59 +0100, Thierry Reding a écrit :
> On Sun, Jan 22, 2017 at 04:47:49PM +0100, Paul Kocialkowski wrote:
> > Nyan boards come with an embedded controller that controls when to
> > enable and disable the charge. Thus, it should not be left up to the
> > kernel to handle that.
> > 
> > Using the ti,external-control property allows specifying this use-case.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> >  arch/arm/boot/dts/tegra124-nyan.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Is the ti,ac-detect-gpios property still useful in that case? I guess it
> would still allow to monitor whether or not a charger is connected, even
> if the EC determines that it shouldn't charge.

Yes, this is mostly what the bq24735 is used for in nyan devices: reporting
connection and disconnection events.

> Anyway, I've applied this.

Thanks!

-- 
Paul Kocialkowski, developer of free digital technology at the lower levels

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH v2 4/6] ARM: tegra: nyan-blaze: Include compatible revisions for proper detection

[Paul Kocialkowski]

Depthcharge (the payload used with cros devices) will attempt to detect
boards using their revision. This includes all the known revisions for
the nyan-blaze board so that the dtb can be selected preferably.

Defining compatibly revisions allows depthcharge to select the kernel
via the revision it detects instead of using the default kernel. This
allows having a FIT image with multiple kernels for multiple devices.

Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
---
 arch/arm/boot/dts/tegra124-nyan-blaze.dts | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan-blaze.dts b/arch/arm/boot/dts/tegra124-nyan-blaze.dts
index c9582361c26e..aca0828115eb 100644
--- a/arch/arm/boot/dts/tegra124-nyan-blaze.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-blaze.dts
@@ -6,7 +6,13 @@
 
 / {
 	model = "HP Chromebook 14";
-	compatible = "google,nyan-blaze", "google,nyan", "nvidia,tegra124";
+	compatible = "google,nyan-blaze-rev10", "google,nyan-blaze-rev9",
+			"google,nyan-blaze-rev8", "google,nyan-blaze-rev7",
+			"google,nyan-blaze-rev6", "google,nyan-blaze-rev5",
+			"google,nyan-blaze-rev4", "google,nyan-blaze-rev3",
+			"google,nyan-blaze-rev2", "google,nyan-blaze-rev1",
+			"google,nyan-blaze-rev0", "google,nyan-blaze",
+			"google,nyan", "nvidia,tegra124";
 
 	panel: panel {
 		compatible = "samsung,ltn140at29-301";
-- 
2.11.0

Re: [PATCH v2 4/6] ARM: tegra: nyan-blaze: Include compatible revisions for proper detection

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

On Sun, Jan 22, 2017 at 04:47:51PM +0100, Paul Kocialkowski wrote:
> Depthcharge (the payload used with cros devices) will attempt to detect
> boards using their revision. This includes all the known revisions for
> the nyan-blaze board so that the dtb can be selected preferably.
> 
> Defining compatibly revisions allows depthcharge to select the kernel
> via the revision it detects instead of using the default kernel. This
> allows having a FIT image with multiple kernels for multiple devices.
> 
> Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
> ---
>  arch/arm/boot/dts/tegra124-nyan-blaze.dts | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Applied, with the same padding adjustments as 3/6.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 1/6] ARM: tegra: nyan: Use proper IRQ type definitions

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

On Sun, Jan 22, 2017 at 04:47:48PM +0100, Paul Kocialkowski wrote:
> This switches a few interrupt definitions that were using
> GPIO_ACTIVE_HIGH as IRQ type, which is invalid.
> 
> This is mostly a cosmetic change, that doesn't affect any driver.
> 
> Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
> ---
>  arch/arm/boot/dts/tegra124-nyan.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH v2 5/6] ARM: tegra: nyan-big: Proper pinmux for TPM i2c

[Paul Kocialkowski]

This corrects the pinmux for accessing the TPM over the i2c line.
Thus, it allows correctly probing the module, that previously failed with i2c
errors.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 arch/arm/boot/dts/tegra124-nyan-big.dts | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
index f12ece9b76a6..03eedf86dc48 100644
--- a/arch/arm/boot/dts/tegra124-nyan-big.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
@@ -1103,19 +1103,19 @@
 			};
 			cam_i2c_scl_pbb1 {
 				nvidia,pins = "cam_i2c_scl_pbb1";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			cam_i2c_sda_pbb2 {
 				nvidia,pins = "cam_i2c_sda_pbb2";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			pbb3 {
 				nvidia,pins = "pbb3";
-- 
2.11.0

Re: [PATCH v2 5/6] ARM: tegra: nyan-big: Proper pinmux for TPM i2c

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

On Sun, Jan 22, 2017 at 04:47:52PM +0100, Paul Kocialkowski wrote:
> This corrects the pinmux for accessing the TPM over the i2c line.
> Thus, it allows correctly probing the module, that previously failed with i2c
> errors.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  arch/arm/boot/dts/tegra124-nyan-big.dts | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)

I've applied an s/i2c/I2C/ in the commit message and applied this. Can
you also make sure that these changes go into the nyan-big configuration
of the tegra-pinmux-scripts[0]? I know Stephen wants to keep those in
sync with the DTS.

Thanks,
Thierry

[0]: https://github.com/NVIDIA/tegra-pinmux-scripts

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 5/6] ARM: tegra: nyan-big: Proper pinmux for TPM i2c

[Jon Hunter]

On 25/01/17 11:06, Thierry Reding wrote:
> * PGP Signed by an unknown key
> 
> On Sun, Jan 22, 2017 at 04:47:52PM +0100, Paul Kocialkowski wrote:
>> This corrects the pinmux for accessing the TPM over the i2c line.
>> Thus, it allows correctly probing the module, that previously failed with i2c
>> errors.
>>
>> Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
>> ---
>>  arch/arm/boot/dts/tegra124-nyan-big.dts | 20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> I've applied an s/i2c/I2C/ in the commit message and applied this. Can
> you also make sure that these changes go into the nyan-big configuration
> of the tegra-pinmux-scripts[0]? I know Stephen wants to keep those in
> sync with the DTS.
> 
> Thanks,
> Thierry
> 
> [0]: https://github.com/NVIDIA/tegra-pinmux-scripts

Looks like it has already been changed ...

https://github.com/NVIDIA/tegra-pinmux-scripts/commit/5049f75b3099515ffb7f064dcf23568c17aecb01

Jon

-- 
nvpublic

Re: [PATCH v2 5/6] ARM: tegra: nyan-big: Proper pinmux for TPM i2c

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

On Wed, Jan 25, 2017 at 11:10:56AM +0000, Jon Hunter wrote:
> 
> On 25/01/17 11:06, Thierry Reding wrote:
> > * PGP Signed by an unknown key
> > 
> > On Sun, Jan 22, 2017 at 04:47:52PM +0100, Paul Kocialkowski wrote:
> >> This corrects the pinmux for accessing the TPM over the i2c line.
> >> Thus, it allows correctly probing the module, that previously failed with i2c
> >> errors.
> >>
> >> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> >> ---
> >>  arch/arm/boot/dts/tegra124-nyan-big.dts | 20 ++++++++++----------
> >>  1 file changed, 10 insertions(+), 10 deletions(-)
> > 
> > I've applied an s/i2c/I2C/ in the commit message and applied this. Can
> > you also make sure that these changes go into the nyan-big configuration
> > of the tegra-pinmux-scripts[0]? I know Stephen wants to keep those in
> > sync with the DTS.
> > 
> > Thanks,
> > Thierry
> > 
> > [0]: https://github.com/NVIDIA/tegra-pinmux-scripts
> 
> Looks like it has already been changed ...
> 
> https://github.com/NVIDIA/tegra-pinmux-scripts/commit/5049f75b3099515ffb7f064dcf23568c17aecb01

Excellent, no need for any further action then.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH v2 6/6] ARM: tegra: nyan-blaze: Proper pinmux for TPM i2c

[Paul Kocialkowski]

From: Jerome Coste <jerome.coste@etu.utc.fr>

This corrects the pinmux for accessing the TPM over the i2c line.
Thus, it allows correctly probing the module, that previously failed with i2c
errors.
---
 arch/arm/boot/dts/tegra124-nyan-blaze.dts | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan-blaze.dts b/arch/arm/boot/dts/tegra124-nyan-blaze.dts
index aca0828115eb..9df25ca5ab83 100644
--- a/arch/arm/boot/dts/tegra124-nyan-blaze.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-blaze.dts
@@ -1100,19 +1100,19 @@
 			};
 			cam_i2c_scl_pbb1 {
 				nvidia,pins = "cam_i2c_scl_pbb1";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			cam_i2c_sda_pbb2 {
 				nvidia,pins = "cam_i2c_sda_pbb2";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			pbb3 {
 				nvidia,pins = "pbb3";
-- 
2.11.0

Re: [PATCH v2 6/6] ARM: tegra: nyan-blaze: Proper pinmux for TPM i2c

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

On Sun, Jan 22, 2017 at 04:47:53PM +0100, Paul Kocialkowski wrote:
> From: Jerome Coste <jerome.coste-liENgnZMlIJGWvitb5QawA@public.gmane.org>
> 
> This corrects the pinmux for accessing the TPM over the i2c line.
> Thus, it allows correctly probing the module, that previously failed with i2c
> errors.

This is missing a Signed-off-by: from Jerome and you (since you
forwarded the patch). I've added those since I assume that that was
intended and your both willing to provide it.

Other than that, same substitution for "i2c" -> "I2C" as on 5/6, and
please also make sure this change gets into the pinmux configurations.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]