From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Chris Brandt <chris.brandt@renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v4 2/2] clocksource: Add renesas-ostm timer driver
Date: Thu, 26 Jan 2017 10:24:46 +0100 [thread overview]
Message-ID: <20170126092446.GF2021@mai> (raw)
In-Reply-To: <20170126020707.4376-3-chris.brandt@renesas.com>
On Wed, Jan 25, 2017 at 09:07:07PM -0500, Chris Brandt wrote:
> This patch adds a OSTM driver for the Renesas architecture.
> The OS Timer (OSTM) has independent channels that can be
> used as a freerun or interval times.
> This driver uses the first probed device as a clocksource
> and then any additional devices as clock events.
>
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
> ---
> v3:
> * Added more details to commit log
> * Kconfig: SYS_SUPPORTS_RENESAS_OSTM to just RENESAS_OSTM
> * removed all MODULE code (this driver is builtin only)
> * removed items from 'struct ostm_device'
> * changed ioread8 to readb
The iowrite* conversion is missing.
s/iowrite8/writeb/
s/iowrite32/writel/
Other than that the driver looks good to me.
Thanks.
-- Daniel
next prev parent reply other threads:[~2017-01-26 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 2:07 [PATCH v4 0/2] clocksource: Add renesas-ostm timer driver Chris Brandt
[not found] ` <20170126020707.4376-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-01-26 2:07 ` [PATCH v4 1/2] dt-bindings: document renesas-ostm timer Chris Brandt
2017-01-26 2:07 ` [PATCH v4 2/2] clocksource: Add renesas-ostm timer driver Chris Brandt
2017-01-26 9:24 ` Daniel Lezcano [this message]
2017-01-26 13:07 ` Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126092446.GF2021@mai \
--to=daniel.lezcano@linaro.org \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).