From: Simon Horman <horms@verge.net.au>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Chris Brandt <chris.brandt@renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v6 0/3] mmc: sh_mobile_sdhi: fix missing r7s72100 clocks
Date: Thu, 26 Jan 2017 11:30:13 +0100 [thread overview]
Message-ID: <20170126103013.GB27721@verge.net.au> (raw)
In-Reply-To: <CAPDyKFq=K4ZwyMnM2twVHW6K43U+rADBX3KFyc5o0UzR2kb10w@mail.gmail.com>
On Thu, Jan 26, 2017 at 09:07:45AM +0100, Ulf Hansson wrote:
> On 25 January 2017 at 21:28, Chris Brandt <chris.brandt@renesas.com> wrote:
> > At first this started out as a simple typo fix, until I realized
> > that the SDHI in the RZ/A1 has 2 clocks per channel and both need
> > to be turned on/off.
> >
> > This patch series adds the ability to specify 2 clocks instead of
> > just 1, and does so for the RZ/A1 r7s72100.
> >
> > This patch has been tested on an RZ/A1 RSK board. Card detect works
> > fine as well as bind/unbind.
> >
> > v6:
> > * more detailed descritpion in tmio_mmc.txt
> >
> > v5:
> > * Take implementation details out of DT documentation and put into
> > the driver code.
> >
> > v4:
> > * No code changes, only text udpates to explain why there are 2 clocks
> > and why we need to treat them as 1 clock.
> >
> > Chris Brandt (3):
> > mmc: sh_mobile_sdhi: add support for 2 clocks
> > mmc: sh_mobile_sdhi: explain clock bindings
> > ARM: dts: r7s72100: update sdhi clock bindings
> >
> > Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 13 ++++++++++++
> > arch/arm/boot/dts/r7s72100.dtsi | 17 +++++++++++-----
> > drivers/mmc/host/sh_mobile_sdhi.c | 23 ++++++++++++++++++++++
> > include/dt-bindings/clock/r7s72100-clock.h | 6 ++++--
> > 4 files changed, 52 insertions(+), 7 deletions(-)
> >
> > --
> > 2.10.1
> >
> >
>
> Thanks, applied patch1 and patch2 for next. Patch3 is for Simon, I
> guess!? (And I can add Rob's ack afterwards).
Thanks, I will take care of the 3rd patch.
Chris, is it safe to apply the 3rd patch without the first 2 patches
present?
next prev parent reply other threads:[~2017-01-26 10:30 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 20:28 [PATCH v6 0/3] mmc: sh_mobile_sdhi: fix missing r7s72100 clocks Chris Brandt
2017-01-25 20:28 ` [PATCH v6 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks Chris Brandt
2017-01-25 20:28 ` [PATCH v6 2/3] mmc: sh_mobile_sdhi: explain clock bindings Chris Brandt
[not found] ` <20170125202810.16876-3-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-01-30 20:37 ` Rob Herring
2017-01-25 20:28 ` [PATCH v6 3/3] ARM: dts: r7s72100: update sdhi " Chris Brandt
[not found] ` <20170125202810.16876-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-01-26 8:07 ` [PATCH v6 0/3] mmc: sh_mobile_sdhi: fix missing r7s72100 clocks Ulf Hansson
2017-01-26 10:12 ` Wolfram Sang
2017-01-26 12:53 ` Chris Brandt
2017-01-27 8:40 ` Simon Horman
2017-01-27 14:57 ` Ulf Hansson
2017-01-26 10:30 ` Simon Horman [this message]
[not found] ` <20170126103013.GB27721-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-01-26 12:53 ` Chris Brandt
-- strict thread matches above, loose matches on Subject: below --
2017-01-26 14:53 [PATCH 0/4] arm64: renesas: enable M3ULCB board peripherals Vladimir Barinov
2017-01-26 14:54 ` [PATCH 1/4] arm64: dts: m3ulcb: enable I2C Vladimir Barinov
2017-02-01 12:35 ` Geert Uytterhoeven
2017-01-26 14:54 ` [PATCH 2/4] arm64: dts: m3ulcb: Update memory node to 2 GiB map Vladimir Barinov
2017-02-01 12:38 ` Geert Uytterhoeven
2017-02-02 18:19 ` Geert Uytterhoeven
2017-02-02 18:21 ` Vladimir Barinov
2017-01-26 14:54 ` [PATCH 3/4] arm64: dts: m3ulcb: enable EthernetAVB Vladimir Barinov
2017-02-01 13:10 ` Geert Uytterhoeven
2017-01-26 14:54 ` [PATCH 4/4] arm64: dts: m3ulcb: enable HS200 for eMMC Vladimir Barinov
[not found] ` <1485442422-18259-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-03-17 22:02 ` [PATCH 0/4] arm64: renesas: enable M3ULCB board peripherals Sjoerd Simons
[not found] ` <1489788135.8957.2.camel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2017-04-06 9:53 ` Geert Uytterhoeven
2017-04-07 13:52 ` Simon Horman
[not found] ` <20170407135212.GA24096-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-04-08 13:18 ` Simon Horman
2017-04-18 1:01 ` Simon Horman
2017-01-26 15:13 [PATCH 0/2] arm64: renesas: enable H3ULCB " Vladimir Barinov
[not found] ` <1485443606-22566-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-01-26 15:13 ` [PATCH 1/2] arm64: dts: h3ulcb: Update memory node to 4 GiB map Vladimir Barinov
2017-02-01 12:40 ` Geert Uytterhoeven
2017-02-02 9:18 ` Simon Horman
[not found] ` <1485443632-22612-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
[not found] ` <1485442486-18427-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
[not found] ` <1485442469-18378-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
[not found] ` <1485442460-18339-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
[not found] ` <1485442449-18300-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-02-01 13:05 ` [PATCH 4/4] arm64: dts: m3ulcb: enable HS200 for eMMC Geert Uytterhoeven
2017-01-26 15:14 ` [PATCH 2/2] arm64: dts: h3ulcb: " Vladimir Barinov
2017-01-27 8:29 ` Simon Horman
2017-02-01 13:05 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126103013.GB27721@verge.net.au \
--to=horms@verge.net.au \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).