From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 6/8] mfd: exynos-lpass: Add support for clocks Date: Thu, 26 Jan 2017 22:09:53 +0200 Message-ID: <20170126200953.sfyd64qk34th4suh@kozik-lap> References: <1485419634-28331-1-git-send-email-m.szyprowski@samsung.com> <1485419634-28331-7-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1485419634-28331-7-git-send-email-m.szyprowski@samsung.com> Sender: linux-gpio-owner@vger.kernel.org To: Marek Szyprowski Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sylwester Nawrocki , Linus Walleij , Tomasz Figa , Lee Jones , Bartlomiej Zolnierkiewicz List-Id: devicetree@vger.kernel.org On Thu, Jan 26, 2017 at 09:33:52AM +0100, Marek Szyprowski wrote: > Exynos LPASS requires some clocks to be enabled to make any access to its > registers. This patch adds code for handling such clocks. For current set > of registers it is enough to keep sfr0_ctrl clock enabled. Till now it > worked only because those clocks were enabled by bootloader and driver > probe() happened before they were disabled by clock core because of lack > of users. Handling those clocks is also needed to make it possible to > enable support for audio power domain. > > This patch requires adding sfr0_ctrl clock to device tree. > > Signed-off-by: Marek Szyprowski > --- > .../devicetree/bindings/mfd/samsung,exynos5433-lpass.txt | 6 ++++++ > drivers/mfd/exynos-lpass.c | 10 ++++++++++ > 2 files changed, 16 insertions(+) > Thanks for changes. Looks good now. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof