[PATCH 0/2] dt-bindings: deprecate and move i2c/trivial-devices.txt

[PATCH 0/2] dt-bindings: deprecate and move i2c/trivial-devices.txt

[Wolfram Sang]

trivial-devices is cruft and a maintenance pain. I'd like to deprecate it and
suggest refactoring. More details in the patch descriptions.

Let me know what you think.

Thanks,

   Wolfram


Wolfram Sang (2):
  dt-bindings: deprecate trivial-devices.txt for i2c
  dt-bindings: move trivial devices out of i2c subdir

 .../{i2c/trivial-devices.txt => i2c-trivial-devices.txt}       | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
 rename Documentation/devicetree/bindings/{i2c/trivial-devices.txt => i2c-trivial-devices.txt} (98%)

-- 
2.10.2

[PATCH 1/2] dt-bindings: deprecate trivial-devices.txt for i2c

[Wolfram Sang]

The idea to collect trivial devices in a seperate file is coming from
the early DT days and turned out to be a bad decision. It regularly
creates maintenance pain and the information is not where users would
expect it (i2c folder is for i2c bus drivers not clients). Also, we do
not maintain such a file for other subsystems, so we should put an end
to this as well. First step is to deprecate it and mention that it
should be refactored into proper bindings.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
 Documentation/devicetree/bindings/i2c/trivial-devices.txt | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
index cdd7b48826c38f..39570a1ca5919f 100644
--- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
+++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
@@ -1,11 +1,15 @@
+*** This file is DEPRECATED! ***
+
 This is a list of trivial i2c devices that have simple device tree
 bindings, consisting only of a compatible field, an address and
 possibly an interrupt line.
 
-If a device needs more specific bindings, such as properties to
-describe some aspect of it, there needs to be a specific binding
-document for it just like any other devices.
+The entries here need to be refactored to proper binding descriptions in
+their relevant subdirectories.
+
+New items will not be added to this file.
 
+*** This file is DEPRECATED! ***
 
 Compatible		Vendor / Chip
 ==========		=============
-- 
2.10.2

[PATCH 2/2] dt-bindings: move trivial devices out of i2c subdir

[Wolfram Sang]

The i2c folder is for i2c bus drivers, not clients. Move the now
deprecated trivial devices file to the bindings base directory, so it
can be refactored from there to proper bindings in the relevant
subdirectories. This will ease maintenance for the I2C subsystem (less
irrelevant patches automatically CCed by get_maintainer.pl) and it will
make aware that we deal with the file differently now.

Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
---
 .../bindings/{i2c/trivial-devices.txt => i2c-trivial-devices.txt}         | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/{i2c/trivial-devices.txt => i2c-trivial-devices.txt} (100%)

diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c-trivial-devices.txt
similarity index 100%
rename from Documentation/devicetree/bindings/i2c/trivial-devices.txt
rename to Documentation/devicetree/bindings/i2c-trivial-devices.txt
-- 
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] dt-bindings: deprecate trivial-devices.txt for i2c

[Rob Herring]

On Thu, Jan 26, 2017 at 11:55:43PM +0100, Wolfram Sang wrote:
> The idea to collect trivial devices in a seperate file is coming from
> the early DT days and turned out to be a bad decision. It regularly
> creates maintenance pain and the information is not where users would
> expect it (i2c folder is for i2c bus drivers not clients). Also, we do
> not maintain such a file for other subsystems, so we should put an end
> to this as well. First step is to deprecate it and mention that it
> should be refactored into proper bindings.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

Actually, I prefer to keep it. Move it up a level and I will take 
patches for it.

Rob

Re: [PATCH 2/2] dt-bindings: move trivial devices out of i2c subdir

[Rob Herring]

On Thu, Jan 26, 2017 at 11:55:44PM +0100, Wolfram Sang wrote:
> The i2c folder is for i2c bus drivers, not clients. Move the now
> deprecated trivial devices file to the bindings base directory, so it
> can be refactored from there to proper bindings in the relevant
> subdirectories. This will ease maintenance for the I2C subsystem (less
> irrelevant patches automatically CCed by get_maintainer.pl) and it will
> make aware that we deal with the file differently now.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>  .../bindings/{i2c/trivial-devices.txt => i2c-trivial-devices.txt}         | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename Documentation/devicetree/bindings/{i2c/trivial-devices.txt => i2c-trivial-devices.txt} (100%)

Just keep the same name. We can use it for SPI too at least.

Re: [PATCH 2/2] dt-bindings: move trivial devices out of i2c subdir

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]


> >  .../bindings/{i2c/trivial-devices.txt => i2c-trivial-devices.txt}         | 0
> >  1 file changed, 0 insertions(+), 0 deletions(-)
> >  rename Documentation/devicetree/bindings/{i2c/trivial-devices.txt => i2c-trivial-devices.txt} (100%)
> 
> Just keep the same name. We can use it for SPI too at least.

OK, will resend with your requested changes.

Thanks!

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 2/2] dt-bindings: move trivial devices out of i2c subdir

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

On Wed, Feb 01, 2017 at 07:35:40PM +0100, Wolfram Sang wrote:
> 
> > >  .../bindings/{i2c/trivial-devices.txt => i2c-trivial-devices.txt}         | 0
> > >  1 file changed, 0 insertions(+), 0 deletions(-)
> > >  rename Documentation/devicetree/bindings/{i2c/trivial-devices.txt => i2c-trivial-devices.txt} (100%)
> > 
> > Just keep the same name. We can use it for SPI too at least.
> 
> OK, will resend with your requested changes.

Thinking about it some more:

Shall I resend now or won't it be easier if I resend at the end of the
next merge window to reduce merge conflicts?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 2/2] dt-bindings: move trivial devices out of i2c subdir

[Rob Herring]

On Tue, Feb 7, 2017 at 5:08 AM, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
> On Wed, Feb 01, 2017 at 07:35:40PM +0100, Wolfram Sang wrote:
>>
>> > >  .../bindings/{i2c/trivial-devices.txt => i2c-trivial-devices.txt}         | 0
>> > >  1 file changed, 0 insertions(+), 0 deletions(-)
>> > >  rename Documentation/devicetree/bindings/{i2c/trivial-devices.txt => i2c-trivial-devices.txt} (100%)
>> >
>> > Just keep the same name. We can use it for SPI too at least.
>>
>> OK, will resend with your requested changes.
>
> Thinking about it some more:
>
> Shall I resend now or won't it be easier if I resend at the end of the
> next merge window to reduce merge conflicts?

Yes, that sounds good.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html