Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

From: Sean Paul <seanpaul@chromium.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	kgene@kernel.org, Donghwa Lee <dh09.lee@samsung.com>,
	linux-kernel@vger.kernel.org, andi.shyti@samsung.com,
	cw00.choi@samsung.com, jh80.chung@samsung.com,
	dri-devel@lists.freedesktop.org,
	Hyungwon Hwang <human.hwang@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Hoegeun Kwon <hoegeun.kwon@samsung.com>
Subject: Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board
Date: Tue, 31 Jan 2017 09:38:53 -0500	[thread overview]
Message-ID: <20170131143853.GU20076@art_vandelay> (raw)
In-Reply-To: <20170131085449.GA19348@ulmo.ba.sec>

On Tue, Jan 31, 2017 at 09:54:49AM +0100, Thierry Reding wrote:
> On Tue, Jan 31, 2017 at 09:01:07AM +0900, Inki Dae wrote:
> > 
> > 
> > 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글:
> > > Dear Thierry,
> > > 
> > > Could you please review this patch?
> > 
> > Thierry, I think this patch has been reviewed enough but no comment
> > from you. Seems you are busy. I will pick up this.
> 
> Sorry, but that's not how it works. This patch has gone through 8
> revisions within 4 weeks, and I tend to ignore patches like that until
> the dust settles.
> 

Seems like the dust was pretty settled. It was posted on 1/11, pinged on 1/24,
and picked up on 1/31. I don't think it's unreasonable to take it through
another tree after that.

I wonder if drm_panel would benefit from the -misc group maintainership model
as drm_bridge does. By spreading out the workload, the high-maintenance
patches would hopefully find someone to shepherd them through.

> Other than that, this continues the same madness that I've repeatedly
> complained about in the past. The whole mechanism of running through a
> series of writes and not caring about errors until the very end is
> something we've discussed at length in the past. It also in large parts
> duplicates a bunch of functions from other Samsung panel drivers that I
> already said should eventually be moved to something saner.
> 

FWIW, this type of error handling isn't my preference either. If we must defer,
I'd rather not keep it in ctx, but rather pass around an argument so it's more
obvious we need to deal with it in the return. That said, this seems like
a case of letting the perfect be the enemy of the good, surely something is
better than nothing?

Sean

> This is now the third driver and nobody's giving a damn about improving
> things.
> 
> Until somebody does, I'm going to have to NAK this.
> 
> Thierry
> 

<snip>

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel