[PATCH] arm64: dts: apq8016-sbc: Add ramoops

[PATCH] arm64: dts: apq8016-sbc: Add ramoops

[Bjorn Andersson]

Declare a ramoops memory segment to aid debugging for those without UART
access. Verified to carry console log when holding volume down for 15
seconds.

I was unable to find any ramoops-like memory region used in the 8916
downstream kernels, so the picked region is the last MB in System RAM.

No memory region for ramoops-like support was found downstrea, so the
arbitrarily picked region is the last MB of System RAM.

Cc: John Stultz <john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Mart Raudsepp <leio-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Cc: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---

Enable CONFIG_PSTORE, CONFIG_PSTORE_CONSOLE and CONFIG_PSTORE_RAM.

 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index a45bc1dba686..f93edf57f249 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -35,6 +35,17 @@
 		stdout-path = "serial0";
 	};
 
+	reserved-memory {
+		ramoops@bff00000{
+			compatible = "ramoops";
+			reg = <0x0 0xbff00000 0x0 0x100000>;
+
+			record-size = <0x20000>;
+			console-size = <0x20000>;
+			ftrace-size = <0x20000>;
+		};
+	};
+
 	soc {
 		dma@7884000 {
 			status = "okay";
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm64: dts: apq8016-sbc: Add ramoops

[Stephen Boyd]

On 02/01, Bjorn Andersson wrote:
> Declare a ramoops memory segment to aid debugging for those without UART
> access. Verified to carry console log when holding volume down for 15
> seconds.
> 
> I was unable to find any ramoops-like memory region used in the 8916
> downstream kernels, so the picked region is the last MB in System RAM.
> 
> No memory region for ramoops-like support was found downstrea, so the
> arbitrarily picked region is the last MB of System RAM.

Same comment twice? Otherwise it looks ok to me as long as you're
willing to lose an MB of ram. Does the kernel skip reserving the
ramoops memory if ramoops isn't enabled? That would be nice to do
so we don't lose memory if we're not enabling the driver.

Acked-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project