From: Lukasz Majewski <lukma@denx.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"David S. Miller" <davem@davemloft.net>,
Mugunthan V N <mugunthanvnm@ti.com>,
Karicheri Muralidharan <m-karicheri2@ti.com>,
linux-kernel@vger.kernel.org, Eric Engestrom <eric@engestrom.ch>,
netdev@vger.kernel.org, Kishon Vijay Abraham I <kishon@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver
Date: Wed, 1 Feb 2017 23:13:23 +0100 [thread overview]
Message-ID: <20170201231323.732dd327@jawa> (raw)
In-Reply-To: <20170201211440.GG7395@lunn.ch>
Hi Andrew,
> > We would need a tri-state device tree properly:
> >
> > 1. Not defined - do nothing
> > 2. Defined as 0 -> explicitly disable port mirroring
> > 3. Defined as 1 -> explicitly enable port mirriring
> >
> > The "net-phy-lane-swap" only fulfills points 1 and 3 above.
> >
> > In my use case I do need point 2.
>
> Looking at the datasheet, PORT_MIRROR_EN defaults to 0. So it seems
> reasonable to unconditionally set it to 0 when the PHY driver
> loads. Any device which needs a value of 1 can set "net-phy-lane-swap"
Unconditionally setting this field to 0 (as we expect the reset default
setting) seems to me like a good solution.
However, I was not sure if such approach is acceptable by the community.
>
> Andrew
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
next prev parent reply other threads:[~2017-02-01 22:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 14:43 [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver Lukasz Majewski
[not found] ` <1485960215-5148-1-git-send-email-lukma-ynQEQJNshbs@public.gmane.org>
2017-02-01 17:16 ` Andrew Lunn
[not found] ` <20170201171610.GC7395-g2DYL2Zd6BY@public.gmane.org>
2017-02-01 19:05 ` Florian Fainelli
[not found] ` <2f3766f0-42df-6aab-dda1-14022c57fb30-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-01 21:05 ` Lukasz Majewski
2017-02-01 21:12 ` Florian Fainelli
[not found] ` <a287bc1e-3693-02d3-4c58-f1369144efd1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-01 21:16 ` Andrew Lunn
2017-02-01 21:14 ` Andrew Lunn
2017-02-01 22:13 ` Lukasz Majewski [this message]
2017-02-02 1:54 ` Andrew Lunn
2017-02-02 9:17 ` Lukasz Majewski
2017-02-02 13:11 ` Andrew Lunn
[not found] ` <20170202131112.GI4967-g2DYL2Zd6BY@public.gmane.org>
2017-02-02 15:22 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201231323.732dd327@jawa \
--to=lukma@denx.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eric@engestrom.ch \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mark.rutland@arm.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).