Re: [PATCH V2 1/2] dt-bindings: leds: document new led-triggers property

[Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]

Hi!

> >>>>Is this possible to mix various entries in a list assigned to single
> >>>>property?
> >>>>Let's say:
> >>>>trigger-sources =
> >>>>    <&ohci_port1>,
> >>>>    <&ehci_port1>,
> >>>>    <&gpio 1 GPIO_ACTIVE_HIGH>;

Actually... I'm not sure I like the "multiple sources". It is somehow
justified for ohci/ehci_port, because they... represent single
physical port. Could we introduce something for the physical port into
the DTS, too?

> >>>According to my knowledge all elements in the list are elements
> >>>of one array, no matter if they are comma separated or space separated
> >>>in "<>" brackets. DT maintainer would have to confirm that though.
> >>
> >>This matches my knowledge as well.
> >
> >Having that, we would be limited to a list of fixed size
> >tuples IMHO.
> 
> That sounds OK. Now I spent some time thinking about this I think it can work.
> First of all we may need something like #sources-cells to extend our property
> in the future.
> Secondly it should be possible to detect type of phandle node by trying things
> one by one. We should be e.g. able to check is phandle is for GPIO by trying
> of_find_gpiochip_by_xlate.

I am not sure if variable-length parameters here is good idea. Would
be nice to keep it simple... Having the led representing voltage on
gpio line is somehow strange to me. I'd rather have dts explaining
what that voltage means ("it is battery charging signal") and than
have led connected to that...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]