From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Inki Dae <inki.dae@samsung.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/5] soc: samsung: pm_domains: Read domain name from the new label property
Date: Sat, 4 Feb 2017 17:46:57 +0200 [thread overview]
Message-ID: <20170204154657.c4pts6wppsq3wmf2@kozik-lap> (raw)
In-Reply-To: <20170201162554.airhzowkqpyaxqpf@rob-hp-laptop>
On Wed, Feb 01, 2017 at 10:25:54AM -0600, Rob Herring wrote:
> On Mon, Jan 30, 2017 at 01:18:59PM +0100, Marek Szyprowski wrote:
> > Device tree nodes for each power domain should use generic "power-domain"
> > name, so using it as a domain name doesn't give much benefits. This patch
> > adds support for human readable names defined in 'label' property. Such
> > names are visible to userspace and makes debugging much easier. When no
> > 'label' property is found, driver keeps using the name constructed from
> > full node name.
>
> I'm not sure this is really a good use of label. label is intended for
> end user visible things like ports/connectors on a board. It's fine
> here, but I wouldn't want to see it used everywhere.
>
Thanks for comments. We want to use the label here for user visible
output - through dmesg or debugfs. Otherwise, we would have to stick
(always) to more descriptive node names, like "lcd-power-domain@xxxxx".
Best regards,
Krzysztof
prev parent reply other threads:[~2017-02-04 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1485778740-30337-1-git-send-email-m.szyprowski@samsung.com>
[not found] ` <CGME20170130121915eucas1p23aa4f4be912bcd64f9521f6e6b51132f@eucas1p2.samsung.com>
2017-01-30 12:18 ` [PATCH v3 4/5] soc: samsung: pm_domains: Read domain name from the new label property Marek Szyprowski
2017-01-31 19:40 ` Krzysztof Kozlowski
2017-02-01 16:25 ` Rob Herring
2017-02-04 15:46 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170204154657.c4pts6wppsq3wmf2@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).