From: Shawn Guo <shawnguo@kernel.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, jun.nie@linaro.org,
mturquette@baylibre.com, sboyd@codeaurora.org, perex@perex.cz,
tiwai@suse.com, shawn.guo@linaro.org, vinod.koul@intel.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
xie.baoyou@zte.com.cn, chen.chaokai@zte.com.cn,
wang.qiang01@zte.com.cn
Subject: Re: [PATCH v2 2/3] dt: ASoC: zx-i2s: Document for the ZTE zx296718 I2S controller
Date: Tue, 7 Feb 2017 16:30:37 +0800 [thread overview]
Message-ID: <20170207083036.GI3407@dragon> (raw)
In-Reply-To: <1486436571-8682-2-git-send-email-baoyou.xie@linaro.org>
On Tue, Feb 07, 2017 at 11:02:50AM +0800, Baoyou Xie wrote:
> This patch documents the devicetree for the ZTE's zx296718
> I2S audio controller.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> Documentation/devicetree/bindings/sound/zte,zx-i2s.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt b/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt
> index 7e5aa6f..c405561 100644
> --- a/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt
> +++ b/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt
> @@ -1,10 +1,12 @@
> ZTE ZX296702 I2S controller
>
> Required properties:
> - - compatible : Must be "zte,zx296702-i2s"
> + - compatible : Should include one of the following strings:
> + "zte,zx296702-i2s","zte,zx296718-i2s".
> - reg : Must contain I2S core's registers location and length
> - clocks : Pairs of phandle and specifier referencing the controller's clocks.
> - - clock-names: "tx" for the clock to the I2S interface.
> + - clock-names: "tx" for the wclk, "pclk" for the pclk to the I2S interface.
> + must contain pclk for zx296718 SoC.
The 'pclk' is really required for zx296702-i2s as well. The driver may
happen to work on zx296702 only because 'pclk' is already enabled by
someone else before I2S driver starts working.
Shawn
> - dmas: Pairs of phandle and specifier for the DMA channel that is used by
> the core. The core expects two dma channels for transmit.
> - dma-names : Must be "tx" and "rx"
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-02-07 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 3:02 [PATCH v2 1/3] clk: zte: add i2s clocks for zx296718 Baoyou Xie
2017-02-07 3:02 ` [PATCH v2 2/3] dt: ASoC: zx-i2s: Document for the ZTE zx296718 I2S controller Baoyou Xie
2017-02-07 8:30 ` Shawn Guo [this message]
2017-02-07 12:02 ` Mark Brown
2017-02-07 3:02 ` [PATCH v2 3/3] ASoC: zx-i2s: support zx296718 SoC for ZTE's i2s controller driver Baoyou Xie
2017-02-07 8:26 ` Shawn Guo
2017-02-07 8:09 ` [PATCH v2 1/3] clk: zte: add i2s clocks for zx296718 Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207083036.GI3407@dragon \
--to=shawnguo@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=baoyou.xie@linaro.org \
--cc=broonie@kernel.org \
--cc=chen.chaokai@zte.com.cn \
--cc=devicetree@vger.kernel.org \
--cc=jun.nie@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=shawn.guo@linaro.org \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
--cc=wang.qiang01@zte.com.cn \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).