From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration Date: Thu, 9 Feb 2017 09:45:07 +0800 Message-ID: <20170209014507.GA565@b29397-desktop> References: <1486372421-29073-1-git-send-email-peter.chen@nxp.com> <1486372421-29073-7-git-send-email-peter.chen@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Vivek Gautam Cc: Mark Rutland , Peter Chen , Ulf Hansson , Heiko =?iso-8859-1?Q?St=FCbner?= , Stephen Boyd , "linux-kernel@vger.kernel.org" , gary.bisson@boundarydevices.com, Sriram Dash , festevam@gmail.com, stillcompiling@gmail.com, Arnd Bergmann , dbaryshkov@gmail.com, vaibhav.hiremath@linaro.org, krzk@kernel.org, mka@chromium.org, Alan Stern , "devicetree@vger.kernel.org" , mail@maciej.szmigiero.name, Pawel Moll , linux-pm@vger.kernel.org, s.hauer@pengutronix.de, troy.kisky@boundarydevices.com, robh+dt , Mathias Nyman , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Wed, Feb 08, 2017 at 05:27:31PM +0530, Vivek Gautam wrote: > Hi, > > > On Mon, Feb 6, 2017 at 2:43 PM, Peter Chen wrote: > > From: Arnd Bergmann > > > > For xhci-hcd platform device, all the DMA parameters are not > > configured properly, notably dma ops for dwc3 devices. So, set > > the dma for xhci from sysdev. sysdev is pointing to device that > > is known to the system firmware or hardware. > > > > Signed-off-by: Arnd Bergmann > > Signed-off-by: Sriram Dash > > Tested-by: Baolin Wang > > Tested-by: Vivek Gautam > > Tested-by: Alexander Sverdlin > > Signed-off-by: Mathias Nyman > > --- > > This patch doesn't work for me anymore on db820c target [1]. > While the same kernel with reverts of patches [2] [3] and an older > patch [4] by Grygorii Strashko works [5]. > > [1] https://github.com/vivekgautam1/linux/tree/linux-v4.10-rc7-usb-db820c-nonworking > [2] 8c9f2de459c7 usb: dwc3: Do not set dma coherent mask > [3] d64ff406e51e usb: dwc3: use bus->sysdev for DMA configuration > [4] https://lkml.org/lkml/2016/4/25/813 > [5] https://github.com/vivekgautam1/linux/tree/linux-v4.10-rc7-usb-db820c > > The [2] and [3] have already at mainline, you may talk with Felipe about it. -- Best Regards, Peter Chen