From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Willy Tarreau <w@1wt.eu>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: armada-385-synology-ds116: add support for Synology DS116 NAS
Date: Sun, 12 Feb 2017 16:38:55 +0100 [thread overview]
Message-ID: <20170212153855.GA17141@lunn.ch> (raw)
In-Reply-To: <20170212012418.GA17841-K+wRfnb2/UA@public.gmane.org>
On Sun, Feb 12, 2017 at 02:24:18AM +0100, Willy Tarreau wrote:
> On Sun, Feb 12, 2017 at 02:17:44AM +0100, Andrew Lunn wrote:
> > > But won't that squat the I/O address and prevent me from using all the
> > > other codes via the regular serial port ?
> >
> > Nope. That driver hijacks the serial port during shutdown to actually
> > turn the power off. The rest of the time, it does not touch the serial
> > port. Userspace, or the rest of the kernel is free to use it.
>
> OK so I should declare both the serial and the power-off device at the
> same address ? Excuse-me for the dumb question but I'm not much used to
> doing uncommon things in DTS files :-/
Hi Willy
What you have in v2 and v3 looks good. It could be considered a bit of
a hack, two nodes for the same hardware block. But they are used at
different times, normal runtime, and late in the shutdown. So it works
out O.K.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-12 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 9:24 [PATCH] ARM: dts: armada-385-synology-ds116: add support for Synology DS116 NAS Willy Tarreau
[not found] ` <1486805073-15534-1-git-send-email-w-K+wRfnb2/UA@public.gmane.org>
2017-02-12 0:40 ` Andrew Lunn
2017-02-12 0:53 ` Willy Tarreau
[not found] ` <20170212005350.GA18612-K+wRfnb2/UA@public.gmane.org>
2017-02-12 1:17 ` Andrew Lunn
[not found] ` <20170212011744.GB7328-g2DYL2Zd6BY@public.gmane.org>
2017-02-12 1:24 ` Willy Tarreau
[not found] ` <20170212012418.GA17841-K+wRfnb2/UA@public.gmane.org>
2017-02-12 15:38 ` Andrew Lunn [this message]
2017-02-12 15:44 ` Willy Tarreau
[not found] ` <20170212153855.GA17141-g2DYL2Zd6BY@public.gmane.org>
2017-02-12 17:27 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170212153855.GA17141@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).