devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
	Arnaud Ebalard <arno@natisbad.org>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: armada-385-synology-ds116: add support for Synology DS116 NAS
Date: Sun, 12 Feb 2017 16:44:14 +0100	[thread overview]
Message-ID: <20170212154414.GA30384@1wt.eu> (raw)
In-Reply-To: <20170212153855.GA17141@lunn.ch>

On Sun, Feb 12, 2017 at 04:38:55PM +0100, Andrew Lunn wrote:
> On Sun, Feb 12, 2017 at 02:24:18AM +0100, Willy Tarreau wrote:
> > On Sun, Feb 12, 2017 at 02:17:44AM +0100, Andrew Lunn wrote:
> > > > But won't that squat the I/O address and prevent me from using all the
> > > > other codes via the regular serial port ?
> > > 
> > > Nope. That driver hijacks the serial port during shutdown to actually
> > > turn the power off. The rest of the time, it does not touch the serial
> > > port. Userspace, or the rest of the kernel is free to use it.
> > 
> > OK so I should declare both the serial and the power-off device at the
> > same address ? Excuse-me for the dumb question but I'm not much used to
> > doing uncommon things in DTS files :-/
> 
> Hi Willy
> 
> What you have in v2 and v3 looks good. It could be considered a bit of
> a hack, two nodes for the same hardware block. But they are used at
> different times, normal runtime, and late in the shutdown. So it works
> out O.K.

OK thanks for confirming :-)

Willy

  reply	other threads:[~2017-02-12 15:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-11  9:24 [PATCH] ARM: dts: armada-385-synology-ds116: add support for Synology DS116 NAS Willy Tarreau
     [not found] ` <1486805073-15534-1-git-send-email-w-K+wRfnb2/UA@public.gmane.org>
2017-02-12  0:40   ` Andrew Lunn
2017-02-12  0:53     ` Willy Tarreau
     [not found]       ` <20170212005350.GA18612-K+wRfnb2/UA@public.gmane.org>
2017-02-12  1:17         ` Andrew Lunn
     [not found]           ` <20170212011744.GB7328-g2DYL2Zd6BY@public.gmane.org>
2017-02-12  1:24             ` Willy Tarreau
     [not found]               ` <20170212012418.GA17841-K+wRfnb2/UA@public.gmane.org>
2017-02-12 15:38                 ` Andrew Lunn
2017-02-12 15:44                   ` Willy Tarreau [this message]
     [not found]                   ` <20170212153855.GA17141-g2DYL2Zd6BY@public.gmane.org>
2017-02-12 17:27                     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170212154414.GA30384@1wt.eu \
    --to=w@1wt.eu \
    --cc=andrew@lunn.ch \
    --cc=arno@natisbad.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).