From mboxrd@z Thu Jan 1 00:00:00 1970 From: Willy Tarreau Subject: Re: [PATCH] ARM: dts: armada-385-synology-ds116: add support for Synology DS116 NAS Date: Sun, 12 Feb 2017 16:44:14 +0100 Message-ID: <20170212154414.GA30384@1wt.eu> References: <1486805073-15534-1-git-send-email-w@1wt.eu> <20170212004031.GA7328@lunn.ch> <20170212005350.GA18612@1wt.eu> <20170212011744.GB7328@lunn.ch> <20170212012418.GA17841@1wt.eu> <20170212153855.GA17141@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170212153855.GA17141@lunn.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andrew Lunn Cc: Thomas Petazzoni , devicetree@vger.kernel.org, Jason Cooper , Arnaud Ebalard , Gregory Clement , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Sun, Feb 12, 2017 at 04:38:55PM +0100, Andrew Lunn wrote: > On Sun, Feb 12, 2017 at 02:24:18AM +0100, Willy Tarreau wrote: > > On Sun, Feb 12, 2017 at 02:17:44AM +0100, Andrew Lunn wrote: > > > > But won't that squat the I/O address and prevent me from using all the > > > > other codes via the regular serial port ? > > > > > > Nope. That driver hijacks the serial port during shutdown to actually > > > turn the power off. The rest of the time, it does not touch the serial > > > port. Userspace, or the rest of the kernel is free to use it. > > > > OK so I should declare both the serial and the power-off device at the > > same address ? Excuse-me for the dumb question but I'm not much used to > > doing uncommon things in DTS files :-/ > > Hi Willy > > What you have in v2 and v3 looks good. It could be considered a bit of > a hack, two nodes for the same hardware block. But they are used at > different times, normal runtime, and late in the shutdown. So it works > out O.K. OK thanks for confirming :-) Willy