public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Priit Laes <plaes@plaes.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Jonathan Liu <net147@gmail.com>,
	Quentin Schulz <quentin.schulz@free-electrons.com>,
	linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Russell King <linux@armlinux.org.uk>,
	Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/8] drm/sun4i: Add encoder type argument to sun4i_tcon0_mode_set
Date: Mon, 13 Feb 2017 09:32:32 +0100	[thread overview]
Message-ID: <20170213083232.rfezcsr6tcbz7hiw@lukather> (raw)
In-Reply-To: <20170211174405.28395-6-plaes@plaes.org>


[-- Attachment #1.1: Type: text/plain, Size: 1086 bytes --]

On Sat, Feb 11, 2017 at 07:44:02PM +0200, Priit Laes wrote:
> Depending on the output type, we have to enable/disable some
> bits conditionally.
> 
> Signed-off-by: Priit Laes <plaes@plaes.org>
> ---
>  drivers/gpu/drm/sun4i/sun4i_rgb.c  | 2 +-
>  drivers/gpu/drm/sun4i/sun4i_tcon.c | 3 ++-
>  drivers/gpu/drm/sun4i/sun4i_tcon.h | 3 ++-
>  3 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c
> index f5e86fe..3d4eb05 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_rgb.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c
> @@ -179,7 +179,7 @@ static void sun4i_rgb_encoder_mode_set(struct drm_encoder *encoder,
>  	struct sun4i_drv *drv = rgb->drv;
>  	struct sun4i_tcon *tcon = drv->tcon;
>  
> -	sun4i_tcon0_mode_set(tcon, mode);
> +	sun4i_tcon0_mode_set(tcon, mode, DRM_MODE_ENCODER_DAC);

This is not the proper encoder type. You can just use encoder_type in
drm_encoder.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2017-02-13  8:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-11 17:43 [PATCH 0/8] drm/sun4i: Add basic LVDS support for A10 Priit Laes
     [not found] ` <20170211174405.28395-1-plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2017-02-11 17:43   ` [PATCH 1/8] ARM: sunxi_defconfig: Enable simple panel Priit Laes
     [not found]     ` <20170211174405.28395-2-plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2017-02-13  4:06       ` [linux-sunxi] " Chen-Yu Tsai
2017-02-11 17:43   ` [PATCH 2/8] ARM: sun4i: Add display blocks for the sun4i dtsi Priit Laes
2017-02-13  9:16     ` Maxime Ripard
2017-02-13  9:20       ` Chen-Yu Tsai
     [not found]         ` <CAGb2v648uAKxpYaU_qhTLAyfe5snW1LG1VWmm+UMLRSQ5a7DKg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-13 16:46           ` [linux-sunxi] " Priit Laes
     [not found]             ` <1487004405.20308.3.camel-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2017-02-14  8:24               ` Maxime Ripard
2017-04-20  7:23               ` Philippe Fouquet
2017-02-11 17:44   ` [PATCH 3/8] drm/panel: simple: Add support for LG LP097x02-slq2 panel Priit Laes
2017-02-11 17:44   ` [PATCH 4/8] drm/sun4i: Add optional 'mode' property to TCON Priit Laes
     [not found]     ` <20170211174405.28395-5-plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2017-02-12 16:50       ` Philippe Fouquet
2017-02-13  8:14       ` Maxime Ripard
2017-02-11 17:44   ` [PATCH 6/8] drm/sun4i: Add initial LVDS stub Priit Laes
2017-02-11 17:44   ` [PATCH 7/8] drm/sun4i: Add various bits and pieces to enable LVDS support on sun4i Priit Laes
     [not found]     ` <20170211174405.28395-8-plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2017-02-13  8:08       ` Maxime Ripard
2017-02-11 17:44   ` [PATCH 8/8] ARM: dts: sun4i: gemei-g9: Add LVDS display support Priit Laes
2017-02-11 17:44 ` [PATCH 5/8] drm/sun4i: Add encoder type argument to sun4i_tcon0_mode_set Priit Laes
2017-02-13  8:32   ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170213083232.rfezcsr6tcbz7hiw@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=net147@gmail.com \
    --cc=plaes@plaes.org \
    --cc=quentin.schulz@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox