[PATCH 1/1] arm64: dts: r8a7795: add IMR-LX4 support

[PATCH 1/1] arm64: dts: r8a7795: add IMR-LX4 support

[Sergei Shtylyov]

[-- Attachment #1: arm64-dts-r8a7795-add-IMR-LX4-support.patch --]
[-- Type: text/plain, Size: 1853 bytes --]

Describe the IMR-LX4 devices in the R8A7795 device tree.

Based on the original (and large) patch by Konstantin Kozhevnikov
<Konstantin.Kozhevnikov@cogentembedded.com>.

Signed-off-by: Konstantin Kozhevnikov <Konstantin.Kozhevnikov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
This patch is against the 'renesas-devel-20170213-v4.10-rc8' tag of Simon
Horman's 'renesas.git' repo.

 arch/arm64/boot/dts/renesas/r8a7795.dtsi |   32 +++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

Index: renesas/arch/arm64/boot/dts/renesas/r8a7795.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1419,6 +1419,38 @@
 			status = "disabled";
 		};
 
+		imr-lx4@fe860000 {
+			compatible = "renesas,imr-lx4";
+			reg = <0 0xfe860000 0 0x2000>;
+			interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 823>;
+			power-domains = <&sysc R8A7795_PD_A3VC>;
+		};
+
+		imr-lx4@fe870000 {
+			compatible = "renesas,imr-lx4";
+			reg = <0 0xfe870000 0 0x2000>;
+			interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 822>;
+			power-domains = <&sysc R8A7795_PD_A3VC>;
+		};
+
+		imr-lx4@fe880000 {
+			compatible = "renesas,imr-lx4";
+			reg = <0 0xfe880000 0 0x2000>;
+			interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 821>;
+			power-domains = <&sysc R8A7795_PD_A3VC>;
+		};
+
+		imr-lx4@fe890000 {
+			compatible = "renesas,imr-lx4";
+			reg = <0 0xfe890000 0 0x2000>;
+			interrupts = <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 820>;
+			power-domains = <&sysc R8A7795_PD_A3VC>;
+		};
+
 		vspbc: vsp@fe920000 {
 			compatible = "renesas,vsp2";
 			reg = <0 0xfe920000 0 0x8000>;

Re: [PATCH 1/1] arm64: dts: r8a7795: add IMR-LX4 support

[Geert Uytterhoeven]

On Tue, Feb 14, 2017 at 10:02 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Describe the IMR-LX4 devices in the R8A7795 device tree.
>
> Based on the original (and large) patch by Konstantin Kozhevnikov
> <Konstantin.Kozhevnikov@cogentembedded.com>.
>
> Signed-off-by: Konstantin Kozhevnikov <Konstantin.Kozhevnikov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/1] arm64: dts: r8a7795: add IMR-LX4 support

[Sergei Shtylyov]

On 2/15/2017 12:02 AM, Sergei Shtylyov wrote:

> Describe the IMR-LX4 devices in the R8A7795 device tree.
>
> Based on the original (and large) patch by Konstantin Kozhevnikov
> <Konstantin.Kozhevnikov@cogentembedded.com>.
>
> Signed-off-by: Konstantin Kozhevnikov <Konstantin.Kozhevnikov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against the 'renesas-devel-20170213-v4.10-rc8' tag of Simon
> Horman's 'renesas.git' repo.

    The binding was documented in the IMR driver patch. I don't expect it to 
change even if the driver would be rewritten for DRM.

[...]
> Index: renesas/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> ===================================================================
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -1419,6 +1419,38 @@
>  			status = "disabled";
>  		};
>
> +		imr-lx4@fe860000 {
> +			compatible = "renesas,imr-lx4";

    The manual seems to suggest that IMR-LX4 devicec are different between 
7795 and 7796 SoCs, so we may need SoC specific compatibility. I'll look into 
this...

MBR, Sergei

Re: [PATCH 1/1] arm64: dts: r8a7795: add IMR-LX4 support

[Sergei Shtylyov]

On 02/15/2017 12:45 PM, Sergei Shtylyov wrote:

>> Describe the IMR-LX4 devices in the R8A7795 device tree.
>>
>> Based on the original (and large) patch by Konstantin Kozhevnikov
>> <Konstantin.Kozhevnikov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>.
>>
>> Signed-off-by: Konstantin Kozhevnikov
>> <Konstantin.Kozhevnikov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
>>
>> ---
>> This patch is against the 'renesas-devel-20170213-v4.10-rc8' tag of Simon
>> Horman's 'renesas.git' repo.
>
>    The binding was documented in the IMR driver patch. I don't expect it to
> change even if the driver would be rewritten for DRM.
>
> [...]
>> Index: renesas/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> @@ -1419,6 +1419,38 @@
>>              status = "disabled";
>>          };
>>
>> +        imr-lx4@fe860000 {
>> +            compatible = "renesas,imr-lx4";
>
>    The manual seems to suggest that IMR-LX4 devicec are different between 7795

    Devices, of course. :-)

> and 7796 SoCs, so we may need SoC specific compatibility. I'll look into this...

    Found no difference between 7795/7796 (other than performance).

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html