From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Subject: Re: [PATCH 1/2] dt: bindings: fpga: add xilinx slave-serial binding description Date: Thu, 16 Feb 2017 19:51:23 +0100 Message-ID: <20170216195123.5160fe5a@crub> References: <1487257860-31115-1-git-send-email-agust@denx.de> <1487257860-31115-2-git-send-email-agust@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Joshua Clayton Cc: linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alan Tull , Moritz Fischer , Rob Herring , Mark Rutland List-Id: devicetree@vger.kernel.org Hi Joshua, On Thu, 16 Feb 2017 09:24:09 -0800 Joshua Clayton stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: ... >> + fpga_mgr_spi: fpga-spi@0 { >> + compatible = "xlnx,fpga-slave-serial"; >> + spi-max-frequency = <60000000>; >> + spi-cpha; >> + reg = <0>; >> + done-gpio = <&gpio0 9 GPIO_ACTIVE_HIGH>; >> + prog_b-gpio = <&gpio0 29 GPIO_ACTIVE_LOW>; >> + }; >nit: you've put prog_b-gpios and done-gpios in the description, >but the example still has "prog_b-gpio" and "done-gpio" Thanks for catching that! I copy pasted them from my testing .dts but now I see that gpio suffix is deprecated for new gpio bindings. Will fix the example in next patch version. Thanks, Anatolij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html