From: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match
Date: Fri, 17 Feb 2017 09:20:09 +0100 [thread overview]
Message-ID: <20170217082009.GB22723@Red> (raw)
In-Reply-To: <58A47521.9090909-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, Feb 15, 2017 at 07:34:57AM -0800, Frank Rowand wrote:
> On 02/15/17 06:22, Corentin Labbe wrote:
> > This symbol will be needed for the dwmac-sun8i ethernet driver.
> > For letting it to be build as module, of_device_compatible_match need to
> > be exported.
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> > drivers/of/base.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/of/base.c b/drivers/of/base.c
> > index df6f6e3..fba351b 100644
> > --- a/drivers/of/base.c
> > +++ b/drivers/of/base.c
> > @@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device,
> >
> > return score;
> > }
> > +EXPORT_SYMBOL(of_device_compatible_match);
> >
> > /**
> > * of_machine_is_compatible - Test root of device tree for a given compatible value
> >
>
>
>
> Rob's reply to the last person who requested that:
>
> It's not missing because no modules use it. It's generally preferred
> to use a match table and of_match_node.
>
> -Frank
I replace of_device_compatible_match like you said and it works.
Thanks
Corentin Labbe
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-17 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 14:22 [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match Corentin Labbe
[not found] ` <20170215142245.11207-1-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-15 15:34 ` Frank Rowand
[not found] ` <58A47521.9090909-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-17 8:20 ` Corentin Labbe [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-16 13:11 [PATCH] of: Add " Neil Armstrong
[not found] ` <1484572311-6005-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-01-16 15:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217082009.GB22723@Red \
--to=clabbe.montjoie-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).