Re: [PATCH v2 2/2] fpga manager: Add Xilinx slave serial SPI driver

[Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>]

Hi Moritz,

On Mon, 20 Feb 2017 09:27:35 -0800
Moritz Fischer mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org wrote:

>Anatolij,
>
>small nits inline.
...

>> +       gpiod_set_value(conf->prog_b, 1);
>> +
>> +       udelay(1); /* min is 500 ns */  
>
>Maybe make this a named constant.

Okay, I can add

  const size_t prog_pulse_us = 1;
  ...
  udelay(prog_pulse_us);

...
>> +       gpiod_set_value(conf->prog_b, 0);
>> +
>> +       if (gpiod_get_value(conf->done)) {
>> +               dev_err(&mgr->dev, "Unexpected DONE pin state...\n");
>> +               return -EIO;
>> +       }
>> +
>> +       /* program latency */
>> +       usleep_range(1000, 1500);  
>
>Same here.

Okay, will change here as well.

Thanks for review! I'll wait some time for more comments and
will submit v3 then.

Anatolij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html