From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jonathan Cameron <jic23@kernel.org>,
sre@kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
letux-kernel@openphoenux.org
Subject: Re: [PATCH 1/3] Input: tsc2007 - rename function tsc2007_calculate_pressure to tsc2007_calculate_resistance because that is what it does
Date: Thu, 23 Feb 2017 00:45:10 -0800 [thread overview]
Message-ID: <20170223084510.GL18639@dtor-ws> (raw)
In-Reply-To: <5f185322353e02e93e641f64dc1a83392fe025c2.1487609795.git.hns@goldelico.com>
On Mon, Feb 20, 2017 at 05:56:34PM +0100, H. Nikolaus Schaller wrote:
>p Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/tsc2007_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/touchscreen/tsc2007_core.c b/drivers/input/touchscreen/tsc2007_core.c
> index 98dbefc..30b53ca 100644
> --- a/drivers/input/touchscreen/tsc2007_core.c
> +++ b/drivers/input/touchscreen/tsc2007_core.c
> @@ -68,7 +68,7 @@ static void tsc2007_read_values(struct tsc2007 *tsc, struct ts_event *tc)
> tsc2007_xfer(tsc, PWRDOWN);
> }
>
> -u32 tsc2007_calculate_pressure(struct tsc2007 *tsc, struct ts_event *tc)
> +u32 tsc2007_calculate_resistance(struct tsc2007 *tsc, struct ts_event *tc)
> {
> u32 rt = 0;
>
> @@ -77,7 +77,7 @@ u32 tsc2007_calculate_pressure(struct tsc2007 *tsc, struct ts_event *tc)
> tc->x = 0;
>
> if (likely(tc->x && tc->z1)) {
> - /* compute touch pressure resistance using equation #1 */
> + /* compute touch resistance using equation #1 */
> rt = tc->z2 - tc->z1;
> rt *= tc->x;
> rt *= tsc->x_plate_ohms;
> @@ -125,7 +125,7 @@ static irqreturn_t tsc2007_soft_irq(int irq, void *handle)
> tsc2007_read_values(ts, &tc);
> mutex_unlock(&ts->mlock);
>
> - rt = tsc2007_calculate_pressure(ts, &tc);
> + rt = tsc2007_calculate_resistance(ts, &tc);
>
> if (!rt && !ts->get_pendown_state) {
> /*
> @@ -138,7 +138,7 @@ static irqreturn_t tsc2007_soft_irq(int irq, void *handle)
>
> if (rt <= ts->max_rt) {
> dev_dbg(&ts->client->dev,
> - "DOWN point(%4d,%4d), pressure (%4u)\n",
> + "DOWN point(%4d,%4d), resistance (%4u)\n",
> tc.x, tc.y, rt);
>
> input_report_key(input, BTN_TOUCH, 1);
> --
> 2.7.3
>
--
Dmitry
next prev parent reply other threads:[~2017-02-23 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 16:56 [PATCH 0/3] Fix tsc2007 to report ABS_PRESSURE correctly H. Nikolaus Schaller
2017-02-20 16:56 ` [PATCH 1/3] Input: tsc2007 - rename function tsc2007_calculate_pressure to tsc2007_calculate_resistance because that is what it does H. Nikolaus Schaller
2017-02-23 8:45 ` Dmitry Torokhov [this message]
[not found] ` <cover.1487609795.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-20 16:56 ` [PATCH 2/3] Input: tsc2007 - correctly report pressure and not resistance to user space H. Nikolaus Schaller
[not found] ` <9e249276be9e20aab1a74617373bf6587f1acd4b.1487609795.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-21 17:13 ` Sebastian Reichel
2017-02-23 8:45 ` Dmitry Torokhov
2017-02-20 16:56 ` [PATCH 3/3] Input: tsc2007 - add a property "ti,report-resistance" to restore the old pressure reporting state if needed H. Nikolaus Schaller
2017-02-21 11:07 ` Pavel Machek
2017-02-21 11:43 ` H. Nikolaus Schaller
2017-02-21 17:19 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223084510.GL18639@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=jic23@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).