From: Raju Lakkaraju <Raju.Lakkaraju-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Allan.Nielsen-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Subject: Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.
Date: Fri, 24 Feb 2017 11:35:17 +0530 [thread overview]
Message-ID: <20170224060513.GA26086@microsemi.com> (raw)
In-Reply-To: <CAL_JsqJLCe1O7Bv526zAY-s-R1DcnA2O0bpx48dTFGSgeu-Edw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Rob,
Thank you for code review comments.
On Tue, Feb 21, 2017 at 10:42:38AM -0600, Rob Herring wrote:
> EXTERNAL EMAIL
>
>
> > Do i need to change from "vsc8531, led-0-mode" to "mscc, led-0-mode"
> > Is this your suggestion?
>
> Well, there shouldn't be a space there, but yess, mscc is the prefix.
>
> Read my original comments. I also suggested combining this to a single property.
>
Accepted your comment.
Fix the combining into single property and change prefix to mscc.
I sent the latest code for review. Please review and send your comments.
> Rob
---
Thanks,
Raju
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-02-24 6:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 13:40 [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs Raju Lakkaraju
2017-02-08 18:29 ` David Miller
[not found] ` <1486474826-29426-1-git-send-email-Raju.Lakkaraju-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2017-02-15 16:45 ` Rob Herring
2017-02-16 9:06 ` Raju Lakkaraju
2017-02-16 14:19 ` Andrew Lunn
[not found] ` <20170216090646.GA29082-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2017-02-21 16:42 ` Rob Herring
[not found] ` <CAL_JsqJLCe1O7Bv526zAY-s-R1DcnA2O0bpx48dTFGSgeu-Edw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-24 6:05 ` Raju Lakkaraju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170224060513.GA26086@microsemi.com \
--to=raju.lakkaraju-dzo6w/ezyo2tg0buxcxiua@public.gmane.org \
--cc=Allan.Nielsen-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org \
--cc=andrew-g2DYL2Zd6BY@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).