From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: Recommended notation for OPP to avoid DTC warnings Date: Mon, 27 Feb 2017 09:12:05 +0530 Message-ID: <20170227034205.GG7147@vireshk-i7> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Masahiro Yamada Cc: Mark Rutland , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, masahiroy@kernel.org, Linux Kernel Mailing List , Rob Herring , linux-arm-kernel List-Id: devicetree@vger.kernel.org On 26-02-17, 14:18, Masahiro Yamada wrote: > Hi. > > > Decumentation/devicetree/bindings/opp/opp.txt > takes examples like this: > > opp@1000000000 { > opp-hz = /bits/ 64 <1000000000>; > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > opp-suspend; > }; > opp@1100000000 { > opp-hz = /bits/ 64 <1100000000>; > opp-microvolt = <980000 1000000 1010000>; > opp-microamp = <80000>; > clock-latency-ns = <310000>; > }; > opp@1200000000 { > opp-hz = /bits/ 64 <1200000000>; > opp-microvolt = <1025000>; > clock-latency-ns = <290000>; > turbo-mode; > }; > > > If we follow this notation and the device-tree is built with W=1, > DTC warns like follows: > > > Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a > unit name, but no reg property > > > Is there a recommended notation to avoid it? > > Maybe, simply omit the "@" ? I would let Rob suggest something here. -- viresh