From: Viresh Kumar <viresh.kumar@linaro.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
masahiroy@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: Recommended notation for OPP to avoid DTC warnings
Date: Mon, 27 Feb 2017 16:25:33 +0530 [thread overview]
Message-ID: <20170227105533.GA19417@vireshk-i7> (raw)
In-Reply-To: <20170227104445.GE6795@leverpostej>
On 27-02-17, 10:44, Mark Rutland wrote:
> On Sun, Feb 26, 2017 at 02:18:03PM +0900, Masahiro Yamada wrote:
> > Hi.
> >
> >
> > Decumentation/devicetree/bindings/opp/opp.txt
> > takes examples like this:
> >
> > opp@1000000000 {
> > opp-hz = /bits/ 64 <1000000000>;
> > opp-microvolt = <970000 975000 985000>;
> > opp-microamp = <70000>;
> > clock-latency-ns = <300000>;
> > opp-suspend;
> > };
>
> > If we follow this notation and the device-tree is built with W=1,
> > DTC warns like follows:
> >
> > Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
> > unit name, but no reg property
> >
> > Is there a recommended notation to avoid it?
> >
> > Maybe, simply omit the "@" ?
>
> I think just s/@/-/ should be fine, e.g. call the above opp-1000000000.
That's fine with me. I can send a patch to fix all existing users if we all
agree for it.
--
viresh
next prev parent reply other threads:[~2017-02-27 10:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 5:18 Recommended notation for OPP to avoid DTC warnings Masahiro Yamada
2017-02-27 3:42 ` Viresh Kumar
2017-02-27 10:44 ` Mark Rutland
2017-02-27 10:55 ` Viresh Kumar [this message]
2017-02-27 10:58 ` Masahiro Yamada
2017-03-31 2:59 ` Masahiro Yamada
2017-04-10 4:58 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227105533.GA19417@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).