From: Stephen Boyd <sboyd@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Mart Raudsepp <leio@gentoo.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
David Brown <david.brown@linaro.org>,
John Stultz <john.stultz@linaro.org>,
Andy Gross <andy.gross@linaro.org>,
linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: apq8016-sbc: Add ramoops
Date: Mon, 27 Feb 2017 23:19:51 -0800 [thread overview]
Message-ID: <20170228071951.GH25384@codeaurora.org> (raw)
In-Reply-To: <20170201102424.4017-1-bjorn.andersson@linaro.org>
On 02/01, Bjorn Andersson wrote:
> Declare a ramoops memory segment to aid debugging for those without UART
> access. Verified to carry console log when holding volume down for 15
> seconds.
>
> I was unable to find any ramoops-like memory region used in the 8916
> downstream kernels, so the picked region is the last MB in System RAM.
>
> No memory region for ramoops-like support was found downstrea, so the
> arbitrarily picked region is the last MB of System RAM.
Same comment twice? Otherwise it looks ok to me as long as you're
willing to lose an MB of ram. Does the kernel skip reserving the
ramoops memory if ramoops isn't enabled? That would be nice to do
so we don't lose memory if we're not enabling the driver.
Acked-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2017-02-28 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 10:24 [PATCH] arm64: dts: apq8016-sbc: Add ramoops Bjorn Andersson
2017-02-28 7:19 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170228071951.GH25384@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=leio@gentoo.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).