devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] arm64: dts: renesas: Upgrade to PSCI v1.0 to support Suspend-to-RAM
@ 2017-02-24 13:49 Geert Uytterhoeven
  2017-02-24 13:49 ` [PATCH v2 1/2] arm64: dts: r8a7795: " Geert Uytterhoeven
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2017-02-24 13:49 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Khiem Nguyen, linux-renesas-soc, linux-arm-kernel, devicetree,
	Geert Uytterhoeven

	Hi Simon, Magnus,

This patch series upgrades the version of the PSCI firmware, as
advertised in DT on Renesas R-Car Gen3 systems, from v0.2 to v1.0.

Note that this series does not have any runtime effects: as of PSCI
v0.2, PSCI provides a VERSION API.  Hence Linux always detected the
actual version, regardless of what was stated in DT, and enabled v1.0
features like system suspend:

    PSCIv1.0 detected in firmware.

However, it is better to have the real hardware^H^H^H^H^H^H^H^Hfirmware
description in DT.

Changes compared to v1:
  - Keep "arm,psci-0.2".

Tested on Salvator-X (both H3 and M3-W) with firmware v2.16.0, but I do
have old boot logs showing that PSCIv1.0 has been detected for a long
time.

Thanks for applying!

Khiem Nguyen (2):
  arm64: dts: r8a7795: Upgrade to PSCI v1.0 to support Suspend-to-RAM
  arm64: dts: r8a7796: Upgrade to PSCI v1.0 to support Suspend-to-RAM

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.7.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/2] arm64: dts: r8a7795: Upgrade to PSCI v1.0 to support Suspend-to-RAM
  2017-02-24 13:49 [PATCH v2 0/2] arm64: dts: renesas: Upgrade to PSCI v1.0 to support Suspend-to-RAM Geert Uytterhoeven
@ 2017-02-24 13:49 ` Geert Uytterhoeven
  2017-02-24 13:49 ` [PATCH v2 2/2] arm64: dts: r8a7796: " Geert Uytterhoeven
  2017-03-02 15:05 ` [PATCH v2 0/2] arm64: dts: renesas: " Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2017-02-24 13:49 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Khiem Nguyen, linux-renesas-soc, linux-arm-kernel, devicetree,
	Takeshi Kihara, Geert Uytterhoeven

From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>

>From PSCI v1.0, Suspend-to-RAM is supported via SYSTEM_SUSPEND PSCI
function call. Hence, upgrade PSCI version for R-Car H3 to support
Suspend-to-RAM.

The Suspend-to-RAM is highly dependent on ARM Trusted Firwmare support
since necessary callback functions will be registered after a query
to ARM Trusted Firmware about SYSTEM_SUSPEND support.

Since PSCI v1.0 is backward compatible with PSCI v0.2, CPU Hotplug and
CPUIdle should be able to work normally with this change.

Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
[geert: Keep "arm,psci-0.2"]
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Khiem: I've updated your email address.

v2:
  - Keep "arm,psci-0.2".
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index dd2888f0b523f76c..8c43e9d7a6d2f799 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -29,7 +29,7 @@
 	};
 
 	psci {
-		compatible = "arm,psci-0.2";
+		compatible = "arm,psci-1.0", "arm,psci-0.2";
 		method = "smc";
 	};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] arm64: dts: r8a7796: Upgrade to PSCI v1.0 to support Suspend-to-RAM
  2017-02-24 13:49 [PATCH v2 0/2] arm64: dts: renesas: Upgrade to PSCI v1.0 to support Suspend-to-RAM Geert Uytterhoeven
  2017-02-24 13:49 ` [PATCH v2 1/2] arm64: dts: r8a7795: " Geert Uytterhoeven
@ 2017-02-24 13:49 ` Geert Uytterhoeven
  2017-03-02 15:05 ` [PATCH v2 0/2] arm64: dts: renesas: " Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2017-02-24 13:49 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: devicetree, Takeshi Kihara, Geert Uytterhoeven, Khiem Nguyen,
	linux-renesas-soc, linux-arm-kernel

From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>

>From PSCI v1.0, Suspend-to-RAM is supported via SYSTEM_SUSPEND PSCI
function call. Hence, upgrade PSCI version for R-Car M3-W to support
Suspend-to-RAM.

The Suspend-to-RAM is highly dependent on ARM Trusted Firwmare support
since necessary callback functions will be registered after a query
to ARM Trusted Firmware about SYSTEM_SUSPEND support.

Since PSCI v1.0 is backward compatible with PSCI v0.2, CPU Hotplug and
CPUIdle should be able to work normally with this change.

Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
[geert: Keep "arm,psci-0.2"]
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Khiem: I've updated your email address.

v2:
  - Keep "arm,psci-0.2".
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index e664456490ec0cc7..4985274b3c5f4a06 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -29,7 +29,7 @@
 	};
 
 	psci {
-		compatible = "arm,psci-0.2";
+		compatible = "arm,psci-1.0", "arm,psci-0.2";
 		method = "smc";
 	};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/2] arm64: dts: renesas: Upgrade to PSCI v1.0 to support Suspend-to-RAM
  2017-02-24 13:49 [PATCH v2 0/2] arm64: dts: renesas: Upgrade to PSCI v1.0 to support Suspend-to-RAM Geert Uytterhoeven
  2017-02-24 13:49 ` [PATCH v2 1/2] arm64: dts: r8a7795: " Geert Uytterhoeven
  2017-02-24 13:49 ` [PATCH v2 2/2] arm64: dts: r8a7796: " Geert Uytterhoeven
@ 2017-03-02 15:05 ` Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2017-03-02 15:05 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: linux-renesas-soc, devicetree, Magnus Damm, linux-arm-kernel,
	Khiem Nguyen

On Fri, Feb 24, 2017 at 02:49:12PM +0100, Geert Uytterhoeven wrote:
> 	Hi Simon, Magnus,
> 
> This patch series upgrades the version of the PSCI firmware, as
> advertised in DT on Renesas R-Car Gen3 systems, from v0.2 to v1.0.
> 
> Note that this series does not have any runtime effects: as of PSCI
> v0.2, PSCI provides a VERSION API.  Hence Linux always detected the
> actual version, regardless of what was stated in DT, and enabled v1.0
> features like system suspend:
> 
>     PSCIv1.0 detected in firmware.
> 
> However, it is better to have the real hardware^H^H^H^H^H^H^H^Hfirmware
> description in DT.
> 
> Changes compared to v1:
>   - Keep "arm,psci-0.2".
> 
> Tested on Salvator-X (both H3 and M3-W) with firmware v2.16.0, but I do
> have old boot logs showing that PSCIv1.0 has been detected for a long
> time.
> 
> Thanks for applying!

Thanks, I have queued these up for v4.12.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-03-02 15:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-24 13:49 [PATCH v2 0/2] arm64: dts: renesas: Upgrade to PSCI v1.0 to support Suspend-to-RAM Geert Uytterhoeven
2017-02-24 13:49 ` [PATCH v2 1/2] arm64: dts: r8a7795: " Geert Uytterhoeven
2017-02-24 13:49 ` [PATCH v2 2/2] arm64: dts: r8a7796: " Geert Uytterhoeven
2017-03-02 15:05 ` [PATCH v2 0/2] arm64: dts: renesas: " Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).