* [PATCH 1/2] devicetree: add vendor prefix for Winstar Display Corp. @ 2017-03-03 15:21 Richard Genoud 2017-03-03 15:21 ` [PATCH 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD Richard Genoud ` (2 more replies) 0 siblings, 3 replies; 6+ messages in thread From: Richard Genoud @ 2017-03-03 15:21 UTC (permalink / raw) To: Thierry Reding Cc: Rob Herring, Mark Rutland, dri-devel, devicetree, linux-kernel, Richard Genoud Winstar Display Corp. is specialized in LCD displays for embedded products. cf: http://www.winstar.com.tw Signed-off-by: Richard Genoud <richard.genoud@gmail.com> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 16d3b5e7f5d1..56df3afd625a 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -322,6 +322,7 @@ voipac Voipac Technologies s.r.o. wd Western Digital Corp. wexler Wexler winbond Winbond Electronics corp. +winstar Winstar Display Corp. wlf Wolfson Microelectronics wm Wondermedia Technologies, Inc. x-powers X-Powers ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD 2017-03-03 15:21 [PATCH 1/2] devicetree: add vendor prefix for Winstar Display Corp Richard Genoud @ 2017-03-03 15:21 ` Richard Genoud [not found] ` <20170303152156.31370-2-richard.genoud-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-03-12 14:12 ` [PATCH 1/2] devicetree: add vendor prefix for Winstar Display Corp Rob Herring 2017-04-06 21:59 ` Thierry Reding 2 siblings, 1 reply; 6+ messages in thread From: Richard Genoud @ 2017-03-03 15:21 UTC (permalink / raw) To: Thierry Reding Cc: Rob Herring, Mark Rutland, dri-devel, devicetree, linux-kernel, Richard Genoud This adds support for the Winstar Display Co. WF35LTIACD 3.5" QVGA TFT LCD panel, which can be supported by the simple panel driver. Signed-off-by: Richard Genoud <richard.genoud@gmail.com> --- .../bindings/display/panel/winstar,wf35ltiacd | 7 ++++++ drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd diff --git a/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd b/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd new file mode 100644 index 000000000000..68408adf239f --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd @@ -0,0 +1,7 @@ +Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel + +Required properties: +- compatible: should be "winstar,wf35ltiacd" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory. diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 06aaf79de8c8..5d45664c6c0e 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1713,6 +1713,31 @@ static const struct panel_desc urt_umsh_8596md_parallel = { .bus_format = MEDIA_BUS_FMT_RGB666_1X18, }; +static const struct drm_display_mode winstar_wf35ltiacd_mode = { + .clock = 6410, + .hdisplay = 320, + .hsync_start = 320 + 20, + .hsync_end = 320 + 20 + 30, + .htotal = 320 + 20 + 30 + 38, + .vdisplay = 240, + .vsync_start = 240 + 4, + .vsync_end = 240 + 4 + 3, + .vtotal = 240 + 4 + 3 + 15, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc winstar_wf35ltiacd = { + .modes = &winstar_wf35ltiacd_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 70, + .height = 53, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, +}; + static const struct of_device_id platform_of_match[] = { { .compatible = "ampire,am800480r3tmqwa1h", @@ -1892,6 +1917,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "urt,umsh-8596md-20t", .data = &urt_umsh_8596md_parallel, }, { + .compatible = "winstar,wf35ltiacd", + .data = &winstar_wf35ltiacd, + }, { /* sentinel */ } }; ^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <20170303152156.31370-2-richard.genoud-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD [not found] ` <20170303152156.31370-2-richard.genoud-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2017-03-12 14:17 ` Rob Herring 2017-03-13 11:55 ` Richard Genoud 0 siblings, 1 reply; 6+ messages in thread From: Rob Herring @ 2017-03-12 14:17 UTC (permalink / raw) To: Richard Genoud Cc: Thierry Reding, Mark Rutland, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Fri, Mar 03, 2017 at 04:21:56PM +0100, Richard Genoud wrote: > This adds support for the Winstar Display Co. WF35LTIACD 3.5" QVGA TFT > LCD panel, which can be supported by the simple panel driver. > > Signed-off-by: Richard Genoud <richard.genoud-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > .../bindings/display/panel/winstar,wf35ltiacd | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++ > 2 files changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd > > diff --git a/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd b/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd > new file mode 100644 > index 000000000000..68408adf239f > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd > @@ -0,0 +1,7 @@ > +Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel > + > +Required properties: > +- compatible: should be "winstar,wf35ltiacd" > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. Please specify the power supply(ies). I know a lot of bindings haven't, but many panels have more than 1 supply and just relying on simple panel doesn't distinguish whether the panel has 1 supply or you didn't check and it has more than 1. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD 2017-03-12 14:17 ` Rob Herring @ 2017-03-13 11:55 ` Richard Genoud 0 siblings, 0 replies; 6+ messages in thread From: Richard Genoud @ 2017-03-13 11:55 UTC (permalink / raw) To: Rob Herring Cc: Thierry Reding, Mark Rutland, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 12/03/2017 15:17, Rob Herring wrote: > On Fri, Mar 03, 2017 at 04:21:56PM +0100, Richard Genoud wrote: >> This adds support for the Winstar Display Co. WF35LTIACD 3.5" QVGA TFT >> LCD panel, which can be supported by the simple panel driver. >> >> Signed-off-by: Richard Genoud <richard.genoud-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> --- >> .../bindings/display/panel/winstar,wf35ltiacd | 7 ++++++ >> drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++ >> 2 files changed, 35 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd >> >> diff --git a/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd b/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd >> new file mode 100644 >> index 000000000000..68408adf239f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd >> @@ -0,0 +1,7 @@ >> +Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel >> + >> +Required properties: >> +- compatible: should be "winstar,wf35ltiacd" >> + >> +This binding is compatible with the simple-panel binding, which is specified >> +in simple-panel.txt in this directory. > > Please specify the power supply(ies). I know a lot of bindings haven't, > but many panels have more than 1 supply and just relying on simple panel > doesn't distinguish whether the panel has 1 supply or you didn't check > and it has more than 1. > > Rob > Ok, I'll specify the power supply. And I'll add an example, it's always nice to have one. Thanks. Richard. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] devicetree: add vendor prefix for Winstar Display Corp. 2017-03-03 15:21 [PATCH 1/2] devicetree: add vendor prefix for Winstar Display Corp Richard Genoud 2017-03-03 15:21 ` [PATCH 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD Richard Genoud @ 2017-03-12 14:12 ` Rob Herring 2017-04-06 21:59 ` Thierry Reding 2 siblings, 0 replies; 6+ messages in thread From: Rob Herring @ 2017-03-12 14:12 UTC (permalink / raw) To: Richard Genoud; +Cc: Mark Rutland, devicetree, linux-kernel, dri-devel On Fri, Mar 03, 2017 at 04:21:55PM +0100, Richard Genoud wrote: > Winstar Display Corp. is specialized in LCD displays for embedded > products. > cf: http://www.winstar.com.tw > > Signed-off-by: Richard Genoud <richard.genoud@gmail.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <robh@kernel.org> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] devicetree: add vendor prefix for Winstar Display Corp. 2017-03-03 15:21 [PATCH 1/2] devicetree: add vendor prefix for Winstar Display Corp Richard Genoud 2017-03-03 15:21 ` [PATCH 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD Richard Genoud 2017-03-12 14:12 ` [PATCH 1/2] devicetree: add vendor prefix for Winstar Display Corp Rob Herring @ 2017-04-06 21:59 ` Thierry Reding 2 siblings, 0 replies; 6+ messages in thread From: Thierry Reding @ 2017-04-06 21:59 UTC (permalink / raw) To: Richard Genoud Cc: Mark Rutland, devicetree, Rob Herring, linux-kernel, dri-devel [-- Attachment #1.1: Type: text/plain, Size: 381 bytes --] On Fri, Mar 03, 2017 at 04:21:55PM +0100, Richard Genoud wrote: > Winstar Display Corp. is specialized in LCD displays for embedded > products. > cf: http://www.winstar.com.tw > > Signed-off-by: Richard Genoud <richard.genoud@gmail.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. Thierry [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-06 21:59 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-03-03 15:21 [PATCH 1/2] devicetree: add vendor prefix for Winstar Display Corp Richard Genoud 2017-03-03 15:21 ` [PATCH 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD Richard Genoud [not found] ` <20170303152156.31370-2-richard.genoud-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-03-12 14:17 ` Rob Herring 2017-03-13 11:55 ` Richard Genoud 2017-03-12 14:12 ` [PATCH 1/2] devicetree: add vendor prefix for Winstar Display Corp Rob Herring 2017-04-06 21:59 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).