From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property Date: Fri, 3 Mar 2017 12:41:49 -0800 Message-ID: <20170303204148.GA78598@google.com> References: <20170224125506.21533-1-john@metanate.com> <20170224125506.21533-24-john@metanate.com> <20170302215643.GA49163@google.com> <20170303113945.3bd2cbd9.john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170303113945.3bd2cbd9.john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: John Keeping Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sean Paul , Chris Zhong , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Yao List-Id: devicetree@vger.kernel.org On Fri, Mar 03, 2017 at 11:39:45AM +0000, John Keeping wrote: > This reset is required in order to fully reset the internal state of the > MIPI controller. > > Signed-off-by: John Keeping > --- > On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote: > > On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote: > > > + /* > > > + * Note that the reset was not defined in the initial device tree, so > > > + * we have to be prepared for it not being found. > > > + */ > > > + apb_rst = devm_reset_control_get(dev, "apb"); > > > > Did this reset ever get documented in the device tree bindings? I > > couldn't find it. Perhaps a follow-up patch is in order? > > Here's a patch to do that. FWIW: Reviewed-by: Brian Norris Thanks.