From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 11/15] drm/sun4i: tcon: Fix tcon channel 1 backporch calculation Date: Wed, 8 Mar 2017 09:55:41 +0100 Message-ID: <20170308085541.p75lt7hmjzbzzpem@lukather> References: <475aeed1da40d46d8e50420c281a74c32b78c730.1488876832.git-series.maxime.ripard@free-electrons.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3ekb4dmocyjhfaca" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Mike Turquette , Stephen Boyd , dri-devel , Daniel Vetter , David Airlie , Mark Rutland , Rob Herring , devicetree , linux-clk , linux-arm-kernel , linux-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org --3ekb4dmocyjhfaca Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Wed, Mar 08, 2017 at 12:25:59PM +0800, Chen-Yu Tsai wrote: > On Tue, Mar 7, 2017 at 4:56 PM, Maxime Ripard > wrote: > > It seems like what's called a backporch in the datasheet is actually the > > backporch plus the sync period. Fix that in our driver. > > > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > index 93249c5ab1e4..e44217fb4f6f 100644 > > --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > @@ -240,15 +240,14 @@ void sun4i_tcon1_mode_set(struct sun4i_tcon *tcon, struct drm_encoder *encoder, > > SUN4I_TCON1_BASIC2_Y(mode->crtc_vdisplay)); > > > > /* Set horizontal display timings */ > > - bp = mode->crtc_htotal - mode->crtc_hsync_end; > > + bp = mode->crtc_htotal - mode->crtc_hsync_start; > > DRM_DEBUG_DRIVER("Setting horizontal total %d, backporch %d\n", > > mode->htotal, bp); > > regmap_write(tcon->regs, SUN4I_TCON1_BASIC3_REG, > > SUN4I_TCON1_BASIC3_H_TOTAL(mode->crtc_htotal) | > > SUN4I_TCON1_BASIC3_H_BACKPORCH(bp)); > > > > - /* Set vertical display timings */ > > Why remove the comment? I have no idea :) This will be fixed. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --3ekb4dmocyjhfaca--